![]() |
#16 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 27,748
Karma: 197700000
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
You're not downloading an official release asset from my github repository. You're downloading some sort of branch source archive. The download from the plugin's thread here at Mobileread is identical to the one from the latest release on github.
But Sigil will not let you install a plugin whose internal folder name does not match the plugin name. So something strange is still happening here. |
![]() |
![]() |
![]() |
#17 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 27,748
Karma: 197700000
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
I've doubled checked the official release of DOCXImport_v0.2.8.zip from its GitHub release page (https://github.com/dougmassay/docxim...eleases/latest) against the DOCXImport_v0.2.8 from the plugins thread here at Mobileread (https://www.mobileread.com/forums/sh...d.php?t=273966), and the zip archives are identical. The question becomes what you are doing in order to get a malformed/misnamed zip archive installed as a plugin with Sigil's official 'Add Plugin' feature, which will resist installing plugins that don't meet strict naming and structural requirements.
Are you manually modifying the zip you're mistakenly getting from github in order to get it to install, or are you unzipping and manually moving its contents into the plugins folder of Sigil's preferences location? Last edited by DiapDealer; 04-23-2023 at 07:49 AM. |
![]() |
![]() |
Advert | |
|
![]() |
#18 |
Member
![]() Posts: 12
Karma: 10
Join Date: Apr 2023
Device: MacBook ProM1 Max, iPad Pro 4th G, iPhone 13 Pro Max
|
I changed nothing on the ZIP file or the corresponding folder.
I used the Github file in your post here in the forum. https://github.com/dougmassay/docximport-sigil-plugin |
![]() |
![]() |
![]() |
#19 |
Sigil Developer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 7,912
Karma: 5449552
Join Date: Nov 2009
Device: many
|
Ah, you did not actually go to Releases on that page and instead used the Code menu there to get a zip of the source. But how did you install it?
|
![]() |
![]() |
![]() |
#20 |
Member
![]() Posts: 12
Karma: 10
Join Date: Apr 2023
Device: MacBook ProM1 Max, iPad Pro 4th G, iPhone 13 Pro Max
|
Preferences >> Plugins
Added the ZIP file. Last edited by BBouy; 04-24-2023 at 09:41 AM. Reason: Fileupload |
![]() |
![]() |
Advert | |
|
![]() |
#21 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 27,748
Karma: 197700000
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
Yes. Your picture indicates your are downloading a source archive from Github and not an actual release of the plugin.
But again.... It is impossible to install what you downloaded via Preferences >> Plugins >> Add Plugin. Sigil simply won't allow you to install that incorrect zip file. Not without a lot of renaming and restructuring. I just tried it. It doesn't work. |
![]() |
![]() |
![]() |
#22 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 27,748
Karma: 197700000
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
Actually, I must apologize. Sigil IS allowing incorrectly named/structured zip archives to be installed via Add Plugin. It doesn't show up in the list of plugins immediately after adding, but it will be there the next time Sigil is restarted. What's more, the invalid plugin cannot be removed by normal means. Once Sigil is restarted, it will still be there.
This is a bug that needs fixing. Again... apologies. And thank you for bringing this to our attention. |
![]() |
![]() |
![]() |
#23 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 27,748
Karma: 197700000
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
Hmmm.. might not be a bug. But it's still not right. I could have sworn we had more validation than a base_name that doesn't already exist and the presence of a plugin.xml file. @Kevin: didn't it use to check that the name in the plugin.xml matched the folder name and the base name of the zip file?
EDIT: Nevermind. Now I see. The base name of the zip (minus any version info) is checked against the internal folder name to see if they match. If they do match, and a plugin.xml file is present, then Sigil sees the plugin as valid. Which means downloads of branch sources from my github plugin repositories are going to be considered valid. At least for installation purposes. But not for running or removal purposes. That's unfortunate. Last edited by DiapDealer; 04-24-2023 at 12:59 PM. |
![]() |
![]() |
![]() |
|
![]() |
||||
Thread | Thread Starter | Forum | Replies | Last Post |
Problem converting on MacOS Monterrey | dunhill | Conversion | 2 | 11-01-2021 03:20 PM |
running calibre-server via launchd on macOS Big Sur | bhyde | Server | 2 | 06-30-2021 01:11 PM |
Can I build Calibre 4.0 on a native macOS machine running OS X El Capitan 10.11.6? | vaboro | Development | 23 | 10-16-2019 04:37 PM |
Problem with Plugins | Thasaidon | Sigil | 3 | 11-18-2015 03:32 AM |
Installing/Running Plugins | David Kudler | Plugins | 3 | 11-12-2014 11:59 PM |