Some notes about the reuse of defsked sources

Mark Nord · 08-28-2011, 08:06 AM

While experimenting with kbook.kbookPage.draw I came across two (2) issues with defsked sources.

parentheses in calculations are missing

Code:

Original output:
	rct.x = naturalBounds.x + naturalBounds.width - rct.width / 2;
needs to be
	rct.x = naturalBounds.x + (naturalBounds.width - rct.width) / 2;

arrays needs to be initialized before use

As I'm not into phyton it is way over my head to change anything in igorsk great scripts, but just want to let you know.

quisvir · 08-29-2011, 07:20 PM

Thanks for the heads-up Mark

quisvir · 09-06-2011, 10:49 AM

I came across a similar issue that other coders might want to be aware of (although it's pretty obvious if you encounter it): switch statements appear to be missing their break statements. So not only the matching case is executed, but all subsequent cases as well. In some cases this might be intentional, but I've seen some functions malfunction for this reason.

08-28-2011, 08:06 AM	#1
Mark Nord 2B \|\| !2B Posts: 851 Karma: 194010 Join Date: Feb 2010 Location: Austria Device: Sony PRS505/650/T1/tolino vision 5	Some notes about the reuse of defsked sources While experimenting with kbook.kbookPage.draw I came across two (2) issues with defsked sources. parentheses in calculations are missing Code: Original output: rct.x = naturalBounds.x + naturalBounds.width - rct.width / 2; needs to be rct.x = naturalBounds.x + (naturalBounds.width - rct.width) / 2; arrays needs to be initialized before use As I'm not into phyton it is way over my head to change anything in igorsk great scripts, but just want to let you know. Last edited by Mark Nord; 08-28-2011 at 02:32 PM. Reason: typos

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Reuse of Images	crutledge	Sigil	3	05-30-2010 08:55 AM
PRS-600 Reuse PRS-505 original cover?	Pablo	Sony Reader	8	02-27-2010 07:14 AM
Reuse a cracked screen..	conundrum	Sony Reader	2	02-13-2010 09:30 AM
PRS-600 Notes on Notes (not good)	FlyFree	Sony Reader	24	12-08-2009 07:23 PM
1.6 sources	Shaggy	iRex	1	06-24-2009 05:16 AM

08-29-2011, 07:20 PM	#2
quisvir Addict Posts: 238 Karma: 6875 Join Date: Feb 2009 Location: Netherlands Device: Kindle PW2	Thanks for the heads-up Mark

09-06-2011, 10:49 AM	#3
quisvir Addict Posts: 238 Karma: 6875 Join Date: Feb 2009 Location: Netherlands Device: Kindle PW2	I came across a similar issue that other coders might want to be aware of (although it's pretty obvious if you encounter it): switch statements appear to be missing their break statements. So not only the matching case is executed, but all subsequent cases as well. In some cases this might be intentional, but I've seen some functions malfunction for this reason.

Advert