Sigil 2.3.0 crashes when opening Fictionwise epubs

[KevinH]

Originally Posted by BeckyEbook

In Windows, it certainly remembers the maximized window.
I specifically deleted all .ini files to make the test more realistic.

Setting "maximized=true/false" is written and read correctly.
On my single-monitor computer, the fullscreen option always accepts "false".
If I manually change it to "true" it is also stored correctly.
A worse issue is the return to "fullscreen=false" state, because in fullscreen mode there is no visible title bar, so there is nothing left to do but to remove the "geometry" line completely.

I know that the state is recorded in the ini file, I was hoping that the calls to showMaximized and showFullScreen in ReadSettings in MainWindow.cpp can be commented out as that could prevent future race issues.

If you did try after commenting out that line, please let me know.

I just tried commented out those lines in Manjaro Linux and both fullscreen and maxmimized restoring still worked just fine.

So if it did work ok on Windows, I am going to comment them out in master to help prevent future race related bugs.


As for getting out of FullScreen mode, especially in Linux can be a real bear as well.

In macOS you just move the cursor up to the top left cursor of the screen and it will popup the titlebar buttons.

In Manjaro Linux, that did not work, neither did right clicking on where the menu bar might be, nor did using esc. I finally googled it and found that Alt-F3 makes a small menu pop-up that allows you to leave FullScreen mode. Leaving Maximized tate is much easier since the titlebar is always available.

[BeckyEbook]

Yes. Of course, I did the tests AFTER commenting out two lines in the MainWindow.cpp file.

[KevinH]

Originally Posted by DiapDealer

Both Windows and Linux versions of Sigil can remember its maximized Window with those lines commented out, but I don't know the first thing about fullscreen. None of the methods or shortcuts for entering fullscreen mode have ever worked for Sigil for me on Linux or Windows. Ever. I'm not complaining, mind you. I despise fullscreen mode.

I'm pretty sure we'd have to do some sort of coding to fully support fullscreen mode for Sigil on Windows or Linux.

EDIT: the incredible shrinking stacked dockwidget from https://www.mobileread.com/forums/sh...1&postcount=99 still persists, I'm afraid (with or without these recently commented lines)

Okay I will comment them out in master.

As for the incredible shrinking dockwidget bug, it must be platform specific. Something is adjusting the sizes using some sort of algorithm or maybe monitor scaling impacts this and we are seeing multiple instances of rounding down?

I am going to run that test on Linux to see if I can recreate it there.

Update:

Just tested things by putting the Table of Contents on top over the BookBrowser then repeatedly open the same file and the Table of Contents never shrunk one pixel (as I had aligned it at the bottom of an text line).

So I can not recreate this on Linux or macOS. So the bug must be in Qt code someplace.

[DiapDealer]

Linux on Cinnamon DOES in fact remember its fullscreen state after closing and relaunching. *Someone* apparently unassigned the keyboard shortcut to toggle fullscreen on and off! I can't imagine who would do such a thing.

[KevinH]

Originally Posted by BeckyEbook

Yes. Of course, I did the tests AFTER commenting out two lines in the MainWindow.cpp file.

Thanks! I just pushed that change to master. Using comments allows the base.ts to still have the right line numbers! For a future release, I will just remove that code completely.

[BeckyEbook]

Originally Posted by KevinH

In Manjaro Linux, that did not work, neither did right clicking on where the menu bar might be, nor did using esc. I finally googled it and found that Alt-F3 makes a small menu pop-up that allows you to leave FullScreen mode. Leaving Maximized tate is much easier since the titlebar is always available.

There's a workaround in Windows, too, as long as some other application hasn't taken over this system shortcut (e.g. PowerToys).
Alt+Space brings up the application's pop-up menu, where we can select "Resize," zoom out Sigil a bit and safely exit full-screen mode.

[DiapDealer]

Originally Posted by BeckyEbook

There's a workaround in Windows, too, as long as some other application hasn't taken over this system shortcut (e.g. PowerToys).
Alt+Space brings up the application's pop-up menu, where we can select "Resize," zoom out Sigil a bit and safely exit full-screen mode.

But how are you getting Sigil INTO fullscreen mode on Windows? Neither F11, nor alt+Enter have any effect on any of the 3 Windows 10 machines (2 physical and one virtual), that I've tried it on.

[DNSB]

After building the latest version, seems to be working happily.

On Windows 11, I have the taskbar set to autohide so setting Sigil to maximized uses the full screen.

[BeckyEbook]

Originally Posted by DiapDealer

But how are you getting Sigil INTO fullscreen mode on Windows? Neither F11, nor alt+Enter have any effect on any of the 3 Windows 10 machines (2 physical and one virtual), that I've tried it on.

Well...
Sometimes I write too briefly.

For testing, I use two ways:
1. I edit sigil_v6.ini and type:

maximized=false
fullscreen=true

I run the released version 2.3.0 and close it.
Then the geometry is set to fullscreen.
Version 2.3.1 recognizes that the geometry points to fullscreen and I can test.

2. Donate button is often used for me to test, so I plugged myself the code:

void MainWindow::Donate()
{
    if (isFullScreen()) {
        showNormal();
    } else {
    showFullScreen();
    }
}

It works perfectly. Clicking on the heart icon turns the full screen on/off.

I privately use this icon for a different purpose CreateHTMLTOC(); but for full-screen testing this was the easiest solution for me.

[DiapDealer]

OK Thanks! So there's no way to use Windows itself to make Sigil go fullscreen like using F11 with browsers and other Windows apps (and similar built-in toggles on Linux and macOS)? How odd. We may have to make our own official fullscreen toggling button for this like you did.

[mrprobert]

Originally Posted by KevinH

But since the Sigil we ship has been fully stripped of debug symbols none of the Sigil calls in the stack trace can be deciphered.

If you build your own, you can always prevent the symbols from being stripped and then the call stack trace shows you so much more.

The build instructions say, "It is not possible at this time build a Debug version of Sigil with Visual Studio." What development environment is needed to build the Debug version?

[BeckyEbook]

Originally Posted by DiapDealer

We may have to make our own official fullscreen toggling button for this like you did.

If indeed such a decision is made in the future, I am enclosing an icon pack for all sets.
It may come in handy whether it is a new command in the menu with the assigned keyboard shortcut F11, or additionally located somewhere on one of the toolbars.

[DiapDealer]

Originally Posted by mrprobert

The build instructions say, "It is not possible at this time build a Debug version of Sigil with Visual Studio." What development environment is needed to build the Debug version?

A Windows debug build of Sigil is quite involved. Perhaps it's changed since I last gave up, but it used to require having a debug build of Qt and a debug build of Python. The latter may have changed. I haven't tried in a long, long while.

[DiapDealer]

Originally Posted by BeckyEbook

If indeed such a decision is made in the future, I am enclosing an icon pack for all sets.
It may come in handy whether it is a new command in the menu with the assigned keyboard shortcut F11, or additionally located somewhere on one of the toolbars.

Thank you! If the other OSes can do it, there's no reason to leave Windows out if the only thing missing is a toggle mechanism. It's not something I need, but fullscreen clearly exists because some like it.

[mrprobert]

Originally Posted by DiapDealer

A Windows debug build of Sigil is quite involved. Perhaps it's changed since I last gave up, but it used to require having a debug build of Qt and a debug build of Python. The latter may have changed. I haven't tried in a long, long while.

Oh, well. Thanks DiapDealer.