PageEdit-2.3.0 Released

[DiapDealer]

PageEdit-2.3.0

PageEdit version 2.3.0 represents a mix of bug fixes and new features. PageEdit 2.3.0 also marks the first version to only support building with Qt6.

New Features in this release

• move to Qt6 (minimum version 6.4.2), remove support for Qt5 as it cluttered the codebase
• remove the need for Qt6Core5Compat library (use QStringView instead of QStringRef)
• added support for using NFC for search, and for all content, links, hrefs, urls
• added support for Windows Dark mode
• added support for auto dark/light switching for Windows and major Linux desktops to match MacOS

Bug Fixes

• fix broken use of arrow keys when selecting images to insert
• move to Qt 6.7.2 for improved security and bug fixes

--------------------------------- Notes -----------------------------------

The latest PageEdit user guide can always be downloaded from the PageEdit website, or from its own GitHub repository.

The MacOS builds are signed AND notarized.

All PageEdit binary downloads (and source) can be found as assets at the bottom of the PageEdit 2.3.0 Github Release page.

[DiapDealer]

Post reserved for future use.

[DiapDealer]

From a Sigil topic: https://www.mobileread.com/forums/sh...d.php?t=363245

Originally Posted by BetterRed

That's easily, and probably best, done in Page Edit, viz:

On that note; I think I've noticed a bit of a hiccup when pasting rich text into PageEdit 2.3.0 on Windows.

When using "Paste" from the menu, you get the option of choosing to paste plain text when html/rich text is detected on the clipboard. But regardless of which option I choose. Both the unformatted text (with color styles applied) AND the formatted text are being pasted. Resulting in double content.

[KevinH]

A bug! I will look into it.

[DiapDealer]

I recall having to do something to restore the "Paste plain Text" choice in a past version. Something to do with how html fragments were being handled.

[KevinH]

That was fixed earlier. I think we are just missing a return from someplace or the wrong clipboard entry is being used.

[KevinH]

Yes we are missing a return here in the Paste routine in MainWindow.cpp:

if (!html.isEmpty()) {
        QMessageBox msgBox(QMessageBox::Question,
          tr("Clipboard contains HTML formatting"),
          tr("Do you want to paste clipboard data as plain text?"),
          QMessageBox::Yes|QMessageBox::No|QMessageBox::Cancel);
        msgBox.setDefaultButton(QMessageBox::Yes);
        // populate the detailed text window - by HTML
        msgBox.setDetailedText(html);
        int rv = msgBox.exec();
        if (rv == QMessageBox::Yes) {
            m_WebView->triggerPageAction(QWebEnginePage::PasteAndMatchStyle);
        } else if (rv == QMessageBox::No) {
            m_WebView->triggerPageAction(QWebEnginePage::Paste);
        } else {
            // they have hit Cancel so paste nothing
            return;
        }
        return;   // fix missing return
    }

I will push that fix to PageEdit master.

[DiapDealer]

Originally Posted by KevinH

That was fixed earlier. I think we are just missing a return from someplace or the wrong clipboard entry is being used.

I think the fix is what I was recalling. I just knew we'd been in there doing something in the past.

[KevinH]

A simplified version of the fix to prevent double pasting of html content has now been pushed to master.

[BetterRed]

Originally Posted by DiapDealer

From a Sigil topic: https://www.mobileread.com/forums/sh...d.php?t=363245



On that note; I think I've noticed a bit of a hiccup when pasting rich text into PageEdit 2.3.0 on Windows.

When using "Paste" from the menu, you get the option of choosing to paste plain text when html/rich text is detected on the clipboard. But regardless of which option I choose. Both the unformatted text (with color styles applied) AND the formatted text are being pasted. Resulting in double content.

I used Ctrl+C at NYT and Ctrl+V in PE.

But I just repeated the exercise and used Edit->Paste->Yes rather than Ctrl+V… did not get double paste. So I disabled ClipboardFusion (my 3rd party clipboard manager) and did it again… still no double paste. See attached images.

@DD - do you have Windows Clipboard History enabled?

BR

[KevinH]

This bug only exists in PageEdit 2.3.0 when pasting richtext/html. Earlier versions do not have it. I rewrote that code to support use of Unicode NFC Normalization and in so doing inadvertently missed adding a required return.

[BetterRed]

I can now recall reverting to 2.0.2 but I can't remember why, and I didn't attach a note to Page Edit as I would normally do.

Because I cut & paste into PE quite a lot I'll stick with it for the time being.

BR