![]() |
#1 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 27,818
Karma: 198099188
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
PageEdit-2.3.0 Released
PageEdit-2.3.0
PageEdit version 2.3.0 represents a mix of bug fixes and new features. PageEdit 2.3.0 also marks the first version to only support building with Qt6. New Features in this release
Bug Fixes
--------------------------------- Notes ----------------------------------- The latest PageEdit user guide can always be downloaded from the PageEdit website, or from its own GitHub repository. The MacOS builds are signed AND notarized. All PageEdit binary downloads (and source) can be found as assets at the bottom of the PageEdit 2.3.0 Github Release page. |
![]() |
![]() |
![]() |
#2 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 27,818
Karma: 198099188
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
Post reserved for future use.
|
![]() |
![]() |
Advert | |
|
![]() |
#3 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 27,818
Karma: 198099188
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
From a Sigil topic: https://www.mobileread.com/forums/sh...d.php?t=363245
On that note; I think I've noticed a bit of a hiccup when pasting rich text into PageEdit 2.3.0 on Windows. When using "Paste" from the menu, you get the option of choosing to paste plain text when html/rich text is detected on the clipboard. But regardless of which option I choose. Both the unformatted text (with color styles applied) AND the formatted text are being pasted. Resulting in double content. Last edited by DiapDealer; Yesterday at 09:58 AM. |
![]() |
![]() |
![]() |
#4 |
Sigil Developer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 8,019
Karma: 5449552
Join Date: Nov 2009
Device: many
|
A bug! I will look into it.
|
![]() |
![]() |
![]() |
#5 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 27,818
Karma: 198099188
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
I recall having to do something to restore the "Paste plain Text" choice in a past version. Something to do with how html fragments were being handled.
|
![]() |
![]() |
Advert | |
|
![]() |
#6 |
Sigil Developer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 8,019
Karma: 5449552
Join Date: Nov 2009
Device: many
|
That was fixed earlier. I think we are just missing a return from someplace or the wrong clipboard entry is being used.
|
![]() |
![]() |
![]() |
#7 |
Sigil Developer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 8,019
Karma: 5449552
Join Date: Nov 2009
Device: many
|
Yes we are missing a return here in the Paste routine in MainWindow.cpp:
Code:
if (!html.isEmpty()) { QMessageBox msgBox(QMessageBox::Question, tr("Clipboard contains HTML formatting"), tr("Do you want to paste clipboard data as plain text?"), QMessageBox::Yes|QMessageBox::No|QMessageBox::Cancel); msgBox.setDefaultButton(QMessageBox::Yes); // populate the detailed text window - by HTML msgBox.setDetailedText(html); int rv = msgBox.exec(); if (rv == QMessageBox::Yes) { m_WebView->triggerPageAction(QWebEnginePage::PasteAndMatchStyle); } else if (rv == QMessageBox::No) { m_WebView->triggerPageAction(QWebEnginePage::Paste); } else { // they have hit Cancel so paste nothing return; } return; // fix missing return } |
![]() |
![]() |
![]() |
#8 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 27,818
Karma: 198099188
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
|
![]() |
![]() |
![]() |
#9 |
Sigil Developer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 8,019
Karma: 5449552
Join Date: Nov 2009
Device: many
|
A simplified version of the fix to prevent double pasting of html content has now been pushed to master.
|
![]() |
![]() |
![]() |
#10 | |
null operator (he/him)
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 20,850
Karma: 27620684
Join Date: Mar 2012
Location: Sydney Australia
Device: none
|
Quote:
But I just repeated the exercise and used Edit->Paste->Yes rather than Ctrl+V… did not get double paste. So I disabled ClipboardFusion (my 3rd party clipboard manager) and did it again… still no double paste. See attached images. @DD - do you have Windows Clipboard History enabled? BR |
|
![]() |
![]() |
![]() |
#11 |
Sigil Developer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 8,019
Karma: 5449552
Join Date: Nov 2009
Device: many
|
This bug only exists in PageEdit 2.3.0 when pasting richtext/html. Earlier versions do not have it. I rewrote that code to support use of Unicode NFC Normalization and in so doing inadvertently missed adding a required return.
Last edited by KevinH; Yesterday at 09:10 PM. |
![]() |
![]() |
![]() |
#12 |
null operator (he/him)
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 20,850
Karma: 27620684
Join Date: Mar 2012
Location: Sydney Australia
Device: none
|
I can now recall reverting to 2.0.2 but I can't remember why, and I didn't attach a note to Page Edit as I would normally do.
Because I cut & paste into PE quite a lot I'll stick with it for the time being. BR |
![]() |
![]() |
![]() |
|
![]() |
||||
Thread | Thread Starter | Forum | Replies | Last Post |
PageEdit-2.0.2 Released | DiapDealer | Sigil | 9 | 10-31-2023 12:10 PM |
PageEdit-1.9.20 Released | DiapDealer | Sigil | 1 | 09-03-2022 03:15 PM |
PageEdit-1.4.0 Released | DiapDealer | Sigil | 1 | 11-13-2020 01:00 PM |
PageEdit-1.1.0 Released | DiapDealer | Sigil | 6 | 02-09-2020 07:29 PM |
PageEdit-0.8.0 Released | DiapDealer | Sigil | 37 | 08-25-2019 04:14 PM |