Jacket CSS ignored by readers (re-appearing bug)

[DrChiper]

Using the Polish -> Jacket function, the jacket css seems to be ignored again.
This problem was addressed already in the thread below:
https://www.mobileread.com/forums/sho...d.php?t=264868

But in the latest calibre 2.45 (could also in earlier versions, but I happen to stumble on it now ), the problem is back in which the media setting is again erroneously included.

  <meta name="calibre-content" content="jacket"/>
  <style type="text/css" media="screen">
  .cbj_banner {

[kovidgoyal]

That's because you are using a local override of the jacket template. Delete that and you will be fine.

[DrChiper]

Ah, I just checked: hence the culprit is "template.xhtml".

I figured that only the local "stylesheet.css" was used and regarded "template.xhtml" as just some example file.

Oh well, learning all the time.
BTW: must I use that "template.xhtml" when I want to tweak with "stylesheet.css", or is it not needed anymore?

[eschwartz]

Only if you want to override "template.xhtml".

[DrChiper]

Ok. Then we have a possible problem on updates here.
Whenever the template file in the installation location

C:\Program Files (x86)\Calibre2\resources\jacket

is updated, the local override copy

C:\Users\<user>\AppData\Roaming\calibre\resources\jacket

obviously is not. And I do think that users should be made aware of this when template files are updated. Not everybody has the knowledge to know that when a feature is updated, accompanying template files might also be involved.

For instance, I just checked the master template against my local copy and even found a 2nd missing update, so I missed at least 2 updates already.
This might lead to unexpected behavior (and erroneous bug reports )

Perhaps the change logs can include update info on template files?

[PeterT]

Or possibly a warning from calibre if the template in the override location is older than the calibre version.

[theducks]

I can see a 'Reminder' nag box on first run of a new version of Calibre.
(the Nag does not try and determine What was different, only that there IS a local version of a updated mainstream file)

Local Overrides detected: <List>
Review suggested

The question is effort.

1) Simple: Always list overrides at every install
The disadvantage is this soon becomes ignored (not read) like the EULA

2)Tracked: Only List outdated (since last report)
assumes the needed corrections will be applied before the next Calibre update
trickier to track if users skip updates

[BetterRed]

Originally Posted by DrChiper

Perhaps the change logs can include update info on template files?

- IMO a section in the "What's New" that lists changed resources would be adequate.

Maybe someone could write a plugin/utility to list the dates of files in the install and configuration resource directories, highlighting those where the install version is newer than the configuration version.

BR

[eschwartz]

If calibre is going to do anything, it should only report local-copy-is-older-timestamp.

But honestly, I'm not really sure it is a problem (or maybe, it is a low-priority nice-to-have).
Overriding the template is advanced usage IMHO, and anyone who does so should be warned that they will need to keep an eye on that manually.

[kovidgoyal]

I agree with eschwartz. Overriding templates via the resources mechanism is advanced usage, and you are on your own with maintaining those in the face of future changes to builtin resources. After all, the possible changes are not just changes to individual files. For instance, in the future I might decide to re-write the jacket mechanism completely and have it stop using templates in the resources folder at all.

Or a real example is that the currently in progress content server rewrite means that the resources used by the content server completely change. There is no simple mechanism to create a warning for such a complex change.

[DrChiper]

Originally Posted by kovidgoyal

Overriding templates via the resources mechanism is advanced usage, and you are on your own with maintaining those in the face of future changes to builtin resources.

Fair enough, but then I make a humble suggestion to make this very clear for any future users. Currently the calibre user guide just states the following:

calibre allows you to override the static resources, like icons, javascript and templates for the metadata jacket, catalogs, etc. with customized versions that you like.

Perhaps we all can get some prior notification when current functions are deprecated (in some future release) to avoid investing any effort on them or posting irrelevant problem reports.

Just my 2cts.

[eschwartz]

There is no notice to plugin developers when APIs are modified (except universally-breaking changes like the Qt5 switch).

I suppose a warning in the manual wouldn't be a bad idea though.

[DrChiper]

There is no notice to plugin developers when APIs are modified ...

Auch.
My respect for the calibre plugin developers deepens considerably

[eschwartz]

Originally Posted by DrChiper

Auch.
My respect for the calibre plugin developers deepens considerably

To be fair, they don't usually have problems. I don't think Kovid is looking to trip people up, and most things are pretty stable.

And there is extensive documentation available, if you read it yourself.