'Button rotation patch' makes KoReader crash

[denisuu]

Does anyone use KoReader with the 2-disable-hw-button-rotation.lua patch?

Since updating to version my Leaf 2 to 3.5.3 (7f5c78ff3), I've been experiencing crashes whenever I apply the patch and then press the volume up or down button, or swipe to go back.

I tried various versions of KoReader, but it might be a ROM issue, not a KoReader problem. I also tried factory resetting the device.
I expect it to be the case for other Onyx or Android devices too.

Interesting lines in crash.log

07-25 17:13:57.213 V/dlopen  ( 2818): sys_dlopen - loading library /data/user/0/org.koreader.launcher/files/common/ssl.so (in local namespace)
07-25 17:13:57.214 W/linker  ( 2818): Warning: "/data/user/0/org.koreader.launcher/files/common/ssl.so" unused DT entry: DT_RPATH (type 0xf arg 0x129b) (ignoring)
07-25 17:13:57.354 I/KOReader( 2818): Loading plugins from directory: /storage/emulated/0/koreader/plugins/
07-25 17:13:58.613 E/NativeThread( 2818): Failed to run script: frontend/device/input.lua:704: attempt to index field 'rotation_map' (a nil value)

Interesting lines in pidcat.log

Unable to open libbeluga.so: dlopen failed: library "libbeluga.so" not found.'

Full logs:

• crash.log
• pidcat.log
• logcat.log

Github: Koreader page turn buttons do not switch with rotation

[Renate]

I know nothing about KOReader or Lua.
Does the KOReader.apk have any libs in it?
Or does it presume your device is "Lua-ready"?
The easiest would be to add the libbeluga.so (I presume some pun on "Lua") to the KOReader.apk.
Of, course, if this is the only thing that uses Lua maybe it would be more useful to just patch the code that it doesn't need a foreign language to rotate the screen.
Unless KOReader is all Lua???

[Renate]

I still don't have a clue what libbeluga is.
It appears that it is an optional lib used/not used by libandroid_runtime.so
So it's not like it's not finding a required lib.

[denisuu]

Originally Posted by Renate

I still don't have a clue what libbeluga is.
It appears that it is an optional lib used/not used by libandroid_runtime.so
So it's not like it's not finding a required lib.

I have no idea what libbeluga is or whether it's an Android component or something related to KoReader.

Initially, I thought I might have removed too many apps, but even after restoring all uninstalled and disabled apps, and performing a factory reset, the crash persists.

This issue started after Onyx's latest update, I’ve decided not to update anymore. It seems more stuff breaks than it adds benefits for me. I'm even considering restoring a backup to the version the device shipped with.

Maybe I should post this in the KoReader MobileRead Forums?

[Renate]

Curse you! You're making me learn this Lua stuff.

Change your mod as so:

local logger = require("logger")
local Device = require("device")
Device.input.rotation_map = map()
logger.info("Hardware button rotation disabled by user patch")

[denisuu]

Originally Posted by Renate

Curse you! You're making me learn this Lua stuff.

Oh no, the Lua curse is spreading! But seriously, thanks for diving into this. Appreciate you taking the time!

That patch doesn't load.

Error applying patch: /storage/emulated/0/koreader/patches/2-disable-hw-button-rotation.lua

[Renate]

I can't believe I made an error. Me, an experienced (10 minutes) Lua programmer.

Device.input.rotation_map = {[0]={}, [1]={}, [2]={}, [3]={}}

[denisuu]

local logger = require("logger")
local Device = require("device")
Device.input.rotation_map = {[0]={}, [1]={}, [2]={}, [3]={}}
logger.info("Hardware button rotation disabled by user patch")

That fixed it lol, the crashes are gone and the buttons are correctly mapped when I rotate the device.

Thanks again Renate!