![]() |
#1 |
Bookish
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 945
Karma: 1803094
Join Date: Jun 2011
Device: PC, t1, t2, t3, aura 2 v1, clara HD, Libra 2, Libra Color, Nxtpaper 11
|
Jacket CSS ignored by readers (re-appearing bug)
Using the Polish -> Jacket function, the jacket css seems to be ignored again.
This problem was addressed already in the thread below: https://www.mobileread.com/forums/sho...d.php?t=264868 But in the latest calibre 2.45 (could also in earlier versions, but I happen to stumble on it now ![]() Code:
<meta name="calibre-content" content="jacket"/>
<style type="text/css" media="screen">
.cbj_banner {
|
![]() |
![]() |
![]() |
#2 |
creator of calibre
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 44,264
Karma: 23661992
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
|
That's because you are using a local override of the jacket template. Delete that and you will be fine.
|
![]() |
![]() |
Advert | |
|
![]() |
#3 |
Bookish
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 945
Karma: 1803094
Join Date: Jun 2011
Device: PC, t1, t2, t3, aura 2 v1, clara HD, Libra 2, Libra Color, Nxtpaper 11
|
Ah, I just checked: hence the culprit is "template.xhtml".
![]() I figured that only the local "stylesheet.css" was used and regarded "template.xhtml" as just some example file. Oh well, learning all the time. BTW: must I use that "template.xhtml" when I want to tweak with "stylesheet.css", or is it not needed anymore? |
![]() |
![]() |
![]() |
#4 |
Ex-Helpdesk Junkie
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 19,421
Karma: 85397180
Join Date: Nov 2012
Location: The Beaten Path, USA, Roundworld, This Side of Infinity
Device: Kindle Touch fw5.3.7 (Wifi only)
|
Only if you want to override "template.xhtml".
![]() |
![]() |
![]() |
![]() |
#5 |
Bookish
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 945
Karma: 1803094
Join Date: Jun 2011
Device: PC, t1, t2, t3, aura 2 v1, clara HD, Libra 2, Libra Color, Nxtpaper 11
|
Ok. Then we have a possible problem on updates here.
Whenever the template file in the installation location Code:
C:\Program Files (x86)\Calibre2\resources\jacket Code:
C:\Users\<user>\AppData\Roaming\calibre\resources\jacket For instance, I just checked the master template against my local copy and even found a 2nd missing update, so I missed at least 2 updates already. This might lead to unexpected behavior (and erroneous bug reports ![]() Perhaps the change logs can include update info on template files? |
![]() |
![]() |
Advert | |
|
![]() |
#6 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 12,550
Karma: 74358018
Join Date: Nov 2007
Location: Toronto
Device: Libra H2O, Libra Colour
|
Or possibly a warning from calibre if the template in the override location is older than the calibre version.
|
![]() |
![]() |
![]() |
#7 |
Well trained by Cats
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 30,280
Karma: 57979022
Join Date: Aug 2009
Location: The Central Coast of California
Device: Kobo Libra2,Kobo Aura2v1, K4NT(Fixed: New Bat.), Galaxy Tab A
|
I can see a 'Reminder' nag box on first run of a new version of Calibre.
(the Nag does not try and determine What was different, only that there IS a local version of a updated mainstream file) Local Overrides detected: <List> The question is effort.Review suggested 1) Simple: Always list overrides at every install The disadvantage is this soon becomes ignored (not read) like the EULA 2)Tracked: Only List outdated (since last report) assumes the needed corrections will be applied before the next Calibre update trickier to track if users skip updates |
![]() |
![]() |
![]() |
#8 | |
null operator (he/him)
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 20,856
Karma: 27620684
Join Date: Mar 2012
Location: Sydney Australia
Device: none
|
Quote:
![]() Maybe someone could write a plugin/utility to list the dates of files in the install and configuration resource directories, highlighting those where the install version is newer than the configuration version. BR |
|
![]() |
![]() |
![]() |
#9 |
Ex-Helpdesk Junkie
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 19,421
Karma: 85397180
Join Date: Nov 2012
Location: The Beaten Path, USA, Roundworld, This Side of Infinity
Device: Kindle Touch fw5.3.7 (Wifi only)
|
If calibre is going to do anything, it should only report local-copy-is-older-timestamp.
But honestly, I'm not really sure it is a problem (or maybe, it is a low-priority nice-to-have). Overriding the template is advanced usage IMHO, and anyone who does so should be warned that they will need to keep an eye on that manually. |
![]() |
![]() |
![]() |
#10 |
creator of calibre
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 44,264
Karma: 23661992
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
|
I agree with eschwartz. Overriding templates via the resources mechanism is advanced usage, and you are on your own with maintaining those in the face of future changes to builtin resources. After all, the possible changes are not just changes to individual files. For instance, in the future I might decide to re-write the jacket mechanism completely and have it stop using templates in the resources folder at all.
Or a real example is that the currently in progress content server rewrite means that the resources used by the content server completely change. There is no simple mechanism to create a warning for such a complex change. |
![]() |
![]() |
![]() |
#11 | ||
Bookish
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 945
Karma: 1803094
Join Date: Jun 2011
Device: PC, t1, t2, t3, aura 2 v1, clara HD, Libra 2, Libra Color, Nxtpaper 11
|
Quote:
Quote:
Just my 2cts. |
||
![]() |
![]() |
![]() |
#12 |
Ex-Helpdesk Junkie
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 19,421
Karma: 85397180
Join Date: Nov 2012
Location: The Beaten Path, USA, Roundworld, This Side of Infinity
Device: Kindle Touch fw5.3.7 (Wifi only)
|
There is no notice to plugin developers when APIs are modified (except universally-breaking changes like the Qt5 switch).
![]() I suppose a warning in the manual wouldn't be a bad idea though. |
![]() |
![]() |
![]() |
#13 | |
Bookish
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 945
Karma: 1803094
Join Date: Jun 2011
Device: PC, t1, t2, t3, aura 2 v1, clara HD, Libra 2, Libra Color, Nxtpaper 11
|
Quote:
![]() My respect for the calibre plugin developers deepens considerably ![]() |
|
![]() |
![]() |
![]() |
#14 | |
Ex-Helpdesk Junkie
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 19,421
Karma: 85397180
Join Date: Nov 2012
Location: The Beaten Path, USA, Roundworld, This Side of Infinity
Device: Kindle Touch fw5.3.7 (Wifi only)
|
Quote:
![]() And there is extensive documentation available, if you read it yourself. |
|
![]() |
![]() |
![]() |
|
![]() |
||||
Thread | Thread Starter | Forum | Replies | Last Post |
Jacket CSS ignored by readers | Hoods7070 | Library Management | 7 | 09-05-2015 09:17 AM |
[Bug] Inserting 'Jacket' ended up with wrong year | nqk | Calibre | 3 | 05-07-2015 09:26 PM |
Calibre: eBook Viewer - CSS Bug | navjot001 | Library Management | 1 | 03-25-2014 08:55 AM |
Embedded font bug or CSS bug in ADE | JSWolf | ePub | 10 | 06-11-2011 02:34 PM |
Small html/css bug | twaits | Calibre | 5 | 01-12-2010 10:26 AM |