KoboTouch and new tolino devices

[beedaddy]

Since the new tolino devices are based on an adapted Kobo FW, it would be great to have them supported just as the Kobo devices. But since there are some differences (it's firmware version 5.x) it needs some work. What I noticed, for example, is that there seems to be no image tree for the covers anymore.

I did try to adapt the driver to the new devices, and doesn't look too bad. In my case, upoading books and covers seem to work very well. What doesn't work is putting books into collections. I don't know yet, why.

Now I'm not sure where to go from here.

Perhaps someone who is more experienced could have a look at my changes?

At least it seems to not break anything, since my Clara 2E works with the changes as before.

(But of course I don't know what happens when kobo devices go for fw 5.x …)

[beedaddy]

Adding books to collections works now. I've no idea, why "false" in the SQL query doesn't work anymore. Using false (no quotation marks) works. But in both databases (Clara 2E and tolino shine 5), the field is BOOL.

I'm also not sure whether more queries need to be adapted accordingly.

But for me, it looks ok now.

[kovidgoyal]

false without quotation marks is correct in modern sqlite. Thoug it is better to use 0 and 1 for false and true as booleans are stored in sqlite databases as integers it doesnt have a separate boolean datatype. See
https://www.sqlite.org/datatype3.html

[kovidgoyal]

Looking at the rest of the driver, it should probably be 'false'

Try changing

        query = 'SELECT Name FROM Shelf WHERE _IsDeleted = "false"'

to

        query = "SELECT Name FROM Shelf WHERE _IsDeleted = 'false'"

that will hopefully work with both

[beedaddy]

Originally Posted by kovidgoyal

Looking at the rest of the driver, it should probably be 'false'

Yes, that works. Thanks!

[beedaddy]

Originally Posted by kovidgoyal

Looking at the rest of the driver, it should probably be 'false'

Originally Posted by beedaddy

Yes, that works. Thanks!

Wait. No! Doesn't work with 'false'. I did the test first with the wrong (i.e. Kobo) device.

[beedaddy]

And btw, using 0 doesn't work with the Kobo device (Clara 2E).

[kovidgoyal]

Originally Posted by beedaddy

And btw, using 0 doesn't work with the Kobo device (Clara 2E).

yes, false without quotes and 0 are the same thing.

[kovidgoyal]

Hmm well then as far as I can tell the two firmwares are storing different things in that column. Which would imply that kobo is unlikely to ever move to that firmware.

[beedaddy]

So, again I'm not sure where to go from here. Perhaps someone who knows more about this driver could have a look a the changes, if they are problematic in any way. Or should I just create a pull request and see what happens?

[kovidgoyal]

Wait a few days someone else might have something to say, if not create a PR. I dont have accesss to Kobo hardware it isnt sold in my country so I can only make general comments.

[beedaddy]

Good idea. So again, it would be great if someone could take a look at the code changes >>here<<.

[beedaddy]

To sum that up, for me it looks like that, for whatever reason, the kobo firmware 4.x and thus the kobo touch driver use the strings "true" and "false" as boolean values. Which seems not to be correct in a sqlite sense. The (tolino) fw 5.x does it the correct way, using 0 and 1 as boolean values. To not break anything, I had to take care of that different behaviour.

If there are still no objections, I will create a PR soon.

[PeterT]

Has anyone checked to see if the database schema has changed from Kobo to Tolino?

Sent from my Pixel 7a using Tapatalk

[beedaddy]

Originally Posted by PeterT

Has anyone checked to see if the database schema has changed from Kobo to Tolino?

I can only tell about the difference between the dbversion 174 from my Clara 2E and the dbversion 189 from my Tolino Shine 5.

As far as I can tell, a few columns have been added to the content table (isLcpEpub, familySharing, familySharingRelation, subscriptionType, metaDataJson and isAdobeDrm) as well as to the Bookmark table (Color and markupJson).

And then there are a bunch of new tolino_* tables (tolino_author, tolino_bookmark, tolino_bookshelfRevision, tolino_comment, tolino_contentItem, tolino_contentItemPendingDeletions, tolino_dogear, tolino_drmKeysKobo, tolino_skoobeChapter, tolino_tag, tolino_resellerHandshake, tolino_familyMembers, tolino_contentItemExtraData, tolino_recommendations, tolino_contentItemAudioInfo, tolino_downloadInfo, tolino_skoobeReadingTime and tolino_languageConfig).

I've attached a diff.