Experimental FBReader v0.12.10 port

[Iñigo]

UPDATE 2010/12/04 17:10 -> new version v1, now fully features comparable to Mackx's v0.10.7 port

Sources in: https://bitbucket.org/inigoserna/fbreader-dr-0.12.x


Hi there,

during this crazy sleepless night I've been doing some silly things... like compiling last version of FBReader - v0.12.10 - for DR devices.

Unlike my past experiments with v0.12.7, this newer version works ok, being as fast as v0.10.7 port, both in emulator and in my DR800.

Could you please test this on your devices, specially on a DR1000?

Beware that you should backup your v0.10.7 configuration directory before (<SD_CARD>/Programs/_config/.FBReader) in order to return to your normal v0.10.7 version after these tests, as configuration is upgraded, so changed and incompatible with v0.10.x.

I've also noted that some keyshorcuts (long left, long right) must be configured again.

Note this is just a plain compilation of original sources, using Mackx's way, but without additional code (no Mackx's DR tabs support).
Thus, the only changes are:
- configuration directory
- DR port toolbar, with some new icons


If this port works, I think we (me, Mackx ;-)... anyone?) could add the DR "touch":
- make it compatible with tabs
- use system menu:
. toggle fullscreen
. rotate screen
. close doc
. increase font size
. decrease font size
. open preferences dialog
. search word
. go to page


I feel the same speed of v0.10.7 port, with no problems by now, but remember I haven't used it extensively.

I expect your comments,
Iñigo

[Mackx]

Hi Iñigo,

The binary is also running on the DR1000. The 0.10.7 version mapped the down and long-down irex-keys to smallScroll and largeScroll, allowing to scroll down on a chm-page and go to next chm-pages with a long-press. However it seems that the 'actioncodes' in fbreader have changed, so the down-arrow does not have the same effect as before. Currently this does not allow me to scroll down in chm-files. (I still need to check what to change.)

I will see if there are more issues related to the changes in fbreader.

Unfortunately I will not have much time coming days/weeks, so I will do my best and publish progress here.

Marcel.

[Iñigo]

Originally Posted by Mackx

Hi Iñigo,

The binary is also running on the DR1000. The 0.10.7 version mapped the down and long-down irex-keys to smallScroll and largeScroll, allowing to scroll down on a chm-page and go to next chm-pages with a long-press. However it seems that the 'actioncodes' in fbreader have changed, so the down-arrow does not have the same effect as before. Currently this does not allow me to scroll down in chm-files. (I still need to check what to change.)

I will see if there are more issues related to the changes in fbreader.

Unfortunately I will not have much time coming days/weeks, so I will do my best and publish progress here.

Marcel.

Ok, thanks for the quick answer Mackx.

Here there is an extract of my options.xml file. It works perfectly for .fb2 files:

  <group name="Keys">
    <option name="Action0" value="pageForward"/>
    <option name="Action1" value="nextTOCSection"/>
    <option name="Action2" value="previousTOCSection"/>
    <option name="Action3" value="pageBackward"/>
    <option name="Key0" value="&lt;DownArrow&gt;"/>
    <option name="Key1" value="&lt;PageDown&gt;"/>
    <option name="Key2" value="&lt;PageUp&gt;"/>
    <option name="Key3" value="&lt;UpArrow&gt;"/>
    <option name="Number" value="4"/>
  </group>

I've updated the first message with a new version and the source code, nothing new for you ;-)

I'll take a look at the menu code these days.

Iñigo

[Mackx]

See bitbucket for the changes that I made. I will make some time later to give some hints for the menu.

[Iñigo]

Originally Posted by Mackx

See bitbucket for the changes that I made. I will make some time later to give some hints for the menu.

Thanks, that was what I did, I copied & pasted your code yesterday, the v1 includes your changes to make FBReader compatible with DR tabs.

I've been looking at hello-world and techpdf sources, it doesn't look very difficult even for me, so I think I'll make some progress these next days when I get some free time.

Thanks,
Iñigo

[Mackx]

Hi Iñigo,

Some more tips for getting a quick-start with the menus. You can take a look at ipc.c and menu.c in xournal.
Most of the ipc.c file can be used as is, only the on_prepare_unmount(), on_changed_orientation() and the on_status_item_activated() need some attention and the xournal specific include files.
The menu.c has separate functions to:
- Create the menu (menu_init())
- Settings the text of the menu items (menu_set_text())
- Showing the menu (menu_show(), called from ipc.c-on_window_activated())
- Handling menu selections (menu_on_item_activated(), called from ipc.c - on_menu_item().

The menu.c file also shows how to get icons from the local program directories.

ipc_menu_add_menu( MENU_MAIN, GROUP_BROWSE, GROUP_ACTIONS, GROUP_FILE); is used to add 3 sub-groups to the MENU_MAIN-menu. If you do not need tree groups you can use a NULL-pointer for the unused menus. The unused ones should be at the end (If I remember well). (Note that an older version of ipc.c is used, I believe that more menu-groups can be added in newer versions.)
ipc_menu_show_menu( MENU_MAIN ); shows the MENU_MAIN-menu.

I did not yet experiment with sub-menu-items, so I can not support on that part.

Hope this gives you a quick-start with the dr-menus,
Marcel.

[Mackx]

I forgot to mention that the v1 version gets its own tab (as expected) on the DR1000.

[Iñigo]

Hi there,

after fighting with ipc.[ch] and techpdf for some hours at night, I deleted all the work and started from scratch using hello-world. Menu is working now.
Code is at r6 in http://bitbucket.org/inigoserna/fbre....12.x/overview

Next step is to dive into FBReader dark waters and write the functionality.

Iñigo

[Mackx]

Hi Iñigo,

I was inspired by you and also started looking at adding a menu to fbreader.0.10.7. I used some code from xournal and had basically reached the same level as you have. (It was late last night so I decided so send you my progress today, seems we have been working on the same thing last night.)

I also looked at how to trigger the real functionality. It seems that ZLApplication::doAction(const std::string &actionId) in \zlibrary\core\src\application\ZLApplication.cpp should do the trick, but I did not have time to try it yet. It is also used by the toolbar and menu code.


Marcel.

(Next step would be to make the fbreader-DR-menu configurable with an xml-file like all the other stuff in fbreader.)

[Iñigo]

Originally Posted by Mackx

Hi Iñigo,

I was inspired by you and also started looking at adding a menu to fbreader.0.10.7. I used some code from xournal and had basically reached the same level as you have. (It was late last night so I decided so send you my progress today, seems we have been working on the same thing last night.)

I also looked at how to trigger the real functionality. It seems that ZLApplication::doAction(const std::string &actionId) in \zlibrary\core\src\application\ZLApplication.cpp should do the trick, but I did not have time to try it yet. It is also used by the toolbar and menu code.

Marcel.

And the actions definitions are on fbreader/src/fbreader/FBReaderActions.h and fbreader/src/fbreader/FBReaderActionCode.cpp files.

Let's see if I can write the code tonight.

Originally Posted by Mackx

(Next step would be to make the fbreader-DR-menu configurable with an xml-file like all the other stuff in fbreader.)

Uhmmm... I don't think it's a good idea... which other actions would you like to appear?

[Mackx]

Originally Posted by Iñigo

Uhmmm... I don't think it's a good idea... which other actions would you like to appear?

It was not a serious remark, just wanted to keep you busy for any future sleepless nights

[Iñigo]

Originally Posted by Mackx

It was not a serious remark, just wanted to keep you busy for any future sleepless nights

Well, now I'm fighting against my missing C++ skills...

How could I get a reference of ZLGtkApplicationWindow in menu.cpp?

EDIT: new code

In ZLGtkApplicationWindow:ZLGtkApplicationWindow, I've added:

menu_init(this);

And in menu.cpp:

static ZLGtkApplicationWindow *zlgtkappwin;
...
// initialise popup menu
void menu_init ( ZLGtkApplicationWindow *appwin )
{
    ...
    zlgtkappwin = appwin;
...

And finally, in menu.cpp menu_on_item_activated():

zlgtkappwin.application().doAction("toggleFullscreen");

but it doesn't work. Compiler shows this error:

Compiling dr-menu.o ...dr-menu.cpp: In function ‘void menu_on_item_activated(const gchar*, const gchar*, const gchar*, const gchar*)’:
dr-menu.cpp:269: error: request for member ‘application’ in ‘zlgtkappwin’, which is of non-class type ‘ZLGtkApplicationWindow*’

Any hint?


EDIT 2: It's compiling now, have to test on the emu ;-)


EDIT 3: It works! It works!
after some silly issues with the linker menu->fullscreen finally works, so the remaining items should be easy...



Iñigo

[Iñigo]

Ok, here you have a version of FBReader v0.12.10 with working DR menus

The source code for this package is in the r8 at http://bitbucket.org/inigoserna/fbreader-dr-0.12.x

Please test it and provide feedback.

My plans before the v2 release include:
- some testing, aka real reading session for 1 or 2 hours
- clean code
- study if we add/delete menu items... suggestions?
- make FBReader start in fullscreen mode by default
- ...

once this is completed I'll publish the package in non-devel forum, and mark my previous 0.10.x port as obsolete.

Iñigo

[Mackx]

Hi Iñigo,

Great, the menus work fine on my DR1000.

However for me the changed functionality in the FBR 0.12.10 w.r.t. navigating chm-files makes it not yet very usefull. Until now I only used FBR to read chm-files, which could be read using the keys only, with this version I need to use the stylus.
I need to make some time to check how to get a simular 'reading-experience' with this new version.

[fekhner]

I made a short test on a large chm file that I had problems with before and it seems to work very well on DR1000, it indeed creates its own tab ...