Instructions for patching firmware 4.30.18838

[jackie_w]

Originally Posted by Hiperbori

Hello. I make the changes to the yaml files but when I run kobopatch.bat the zip file is not created in the out folder. Why?
the log file that is generated is this:

The answer is clearly stated in the last line of your posted log file:

Originally Posted by Hiperbori

--> patch "Un-force font-family override p tags (std epubs)": more than one patch enabled in PatchGroup "ePub force font alternatives" (other patch is "Force user font-family in ePubs (Part 1 of 2)")

You are only allowed to enable one patch from patches which share the same PatchGroup, in your case PatchGroup "ePub force font alternatives". Decide which patch you actually want and disable the other(s).

[JSWolf]

Why is Disable orphans/widows avoidance: not called Enable orphans/widows avoidance:? The patch enables widows/orphans avoidance not disables.

[DNSB]

Originally Posted by JSWolf

Why is Disable orphans/widows avoidance: not called Enable orphans/widows avoidance:? The patch enables widows/orphans avoidance not disables.

For me, the patch disables the code that avoids widows and orphans. If it enabled widows/orphans avoidance, I would not get a single line at the end of a paragraph being pushed to the head of the next page (widow) or a single line at the start of the paragraph being left at the foot of a page (orphan).

[JSWolf]

Originally Posted by DNSB

For me, the patch disables the code that avoids widows and orphans. If it enabled widows/orphans avoidance, I would not get a single line at the end of a paragraph being pushed to the head of the next page (widow) or a single line at the start of the paragraph being left at the foot of a page (orphan).

I think the problem is the word avoidance. If we got rid of it, then it would make more sense as Disable windows/orphans.

[JSWolf]

Can the patch Unify font sizes: be fixed so it works the reverse way of making KePub match ePub? That way for people that need large font sizes, this will work much better.

[sherman]

Originally Posted by JSWolf

Can the patch Unify font sizes: be fixed so it works the reverse way of making KePub match ePub? That way for people that need large font sizes, this will work much better.

The current patch allows font sizes to get large enough. If a user wants more range in the larger sizes, there's always the Custom font sizes patch that can be adjusted to suit.

The purpose of the Unify font sizes is to unify font sizes between epub, kepub, not "make kepub size bigger".

[davidfor]

Originally Posted by JSWolf

I think the problem is the word avoidance. If we got rid of it, then it would make more sense as Disable windows/orphans.

Except, you want widows and orphans. Disabling widows and orphans means you are not letting widows and orphans occur. And widows are the lines left at the end of the page when the rest of the paragraph is on the next page. Whether that is one line, two lines or more, they are widows. If you disable widows and orphans, it means you don't want widows or orphans. That means a paragraph cannot cross the page boundary (ignoring paragraphs that are too long to fit on a page). Somehow, I think that that would mean a lot more empty space at the end of the screen.

[Daniel Jackson]

When setting patch overrides in kobopatch.yaml, do they need to be in the same order as the actual patches occur in their corresponding yaml files?

[jackie_w]

Originally Posted by Daniel Jackson

When setting patch overrides in kobopatch.yaml, do they need to be in the same order as the actual patches occur in their corresponding yaml files?

No, any order you like as long as they're grouped in the correct .yaml override section.

[Daniel Jackson]

ok, thanks!

[JSWolf]

Originally Posted by sherman

The current patch allows font sizes to get large enough. If a user wants more range in the larger sizes, there's always the Custom font sizes patch that can be adjusted to suit.

The purpose of the Unify font sizes is to unify font sizes between epub, kepub, not "make kepub size bigger".

The original patch before 4.30.18838 made KePub match ePub and I think that works better. The problem is that KePub starts off too small. So this patch means you have to move the slider quite a bit in order to get start getting to a font size you may want. And the other thing, it means every eBook that's been previously opened will have to have the font size adjusted. If the patch worked the way it originally did, then nobody will have to change font sizes.

Is it possible to reverse the patch and match KePub with ePub like has been done ever since the the original patch?

[JSWolf]

Originally Posted by davidfor

Except, you want widows and orphans. Disabling widows and orphans means you are not letting widows and orphans occur. And widows are the lines left at the end of the page when the rest of the paragraph is on the next page. Whether that is one line, two lines or more, they are widows. If you disable widows and orphans, it means you don't want widows or orphans. That means a paragraph cannot cross the page boundary (ignoring paragraphs that are too long to fit on a page). Somehow, I think that that would mean a lot more empty space at the end of the screen.

Disabling widows and orphans means you don't have the extra space at the bottom of the page because there are no widows and orphans to move things around. By default widows and orphans are set to 2. Setting them to 1 or 0 works to stop them from doing anything. That's what this patch is doing. It's stopping widows and orphans from doing anything. If I am wrong, please tell me how so.

[JSWolf]

One thing to be careful about is tabs vs spaces. If there are tabs, they'll need to be converted to spaces because if there are tabs in kobopatch.yaml, that will cause none of the patches to happen. I got caught with a few tabs when I recently setup the patches.

[Sirtel]

Originally Posted by JSWolf

The original patch before 4.30.18838 made KePub match ePub and I think that works better. The problem is that KePub starts off too small. So this patch means you have to move the slider quite a bit in order to get start getting to a font size you may want. And the other thing, it means every eBook that's being opened will have to have the font size adjusted. If the patch worked the way it originally did, then nobody will have to change font sizes.

What? I have the current patch enabled on both the Sage and the Libra and certainly don't have to adjust font sizes when opening a new book.

[JSWolf]

Originally Posted by Sirtel

What? I have the current patch enabled on both the Sage and the Libra and certainly don't have to adjust font sizes when opening a new book.

I made a typo and left out a word. I meant for books that were previously opened. All of those books will need the font slider adjusted and not just a few pushes of the +. And if you just start with a new book after patching, that one will also have to have the font size adjusted. This goes for both ePub and KePub because the previous patch adjusted the KePub size to match ePub. Now it's reversed and that means none of the previously opened books are at the correct font size.

If the patch worked the same as it did before, then no books would need to have the font size adjusted,.