Sigil-2.3.0 Released

[KevinH]

Indeed. Bulk loading of epubs like that was never meant to be. The older versions are your best bet. The separate warning message boxes were actually interfering with restoring the proper Sigil MainWindow and DockWidgets sizes at times. By catching them all and delaying them until after the MainWindow has been activated it prevented that interference.

So we won't be going back. I might think about a "dismiss all" button being added but not fixing these warnings can result in errors that could cause problems for Sigil.

[wildfire070]

Thanks for the quick response! That's what I thought but figured I'd ask just to be sure. I'll switch back to the previous version since it worked out for my use case.

[Turtle91]

Found a little glitch. Granted, it's caused by my screwup, but it might be an easy fix.

The problem: Select all your xhtml files in book browser. Rename, and type in something that would produce a filename error, such as '.html/' (yes, I have less nimble fingers sometimes and my fingers are moving too fast to catch the error before I hit the enter key...) Sigil correctly admonishes me with an error 'A filename cannot contains [sic] the character "/".' BUT, like an old female horse, it continues to admonish me for EVERY file I had selected....

The possible solution: can you exit the rename loop on the first error instead??

[KevinH]

Yes the detection of illegal characters in new file names does not come until quite late in the bulk rename process to better accommodate RegexRename which can generate many different filename pieces derived from the original.

I will duplicate the forbidden character check and add it much earlier in the rename template code and abort out of all renames if any part of the "template" has or uses forbidden characters.

Thanks for your bug report!

Update: I decided it would be best to check the user supplied rename template for forbidden characters and abort the entire rename if there are any issues by adding this routine in RenameSelect() in BookBrowser.cpp:

    if (!template_name.isEmpty()) {
        // Verify the template name does not have any forbidden chars in the name                                                       
        const QString badchars = "<>:\"/\\|?*";
        bool has_bad_chars = false;
        foreach(QChar ch, template_name) {
            has_bad_chars = has_bad_chars || badchars.contains(ch);
        }
        if (has_bad_chars) {
            Utility::DisplayStdErrorDialog(tr("Filenames can not contain these characters: \"%1\".").arg(badchars));
            return;
        }
    }

That seems to have done the trick for the case you reported. I have now pushed this to master.

[Turtle91]

Awesome! Thank you!!

[pete6055]

Originally Posted by KevinH

@DiapDealer and @BeckyEbook



Great! I will push that fix to master.

Update: Fix now in master

Hi,

When you push a fix to the master, where can it be retrieved? I assumed it would be reflected in the executable for download, but I am still getting double epub opening warnings on Windows after I refreshed my download.

Thanks

[DNSB]

Originally Posted by pete6055

Hi,

When you push a fix to the master, where can it be retrieved? I assumed it would be reflected in the executable for download, but I am still getting double epub opening warnings on Windows after I refreshed my download.

Thanks

Unless you are compiling Sigil yourself, any changes pushed to master will be seen in the next release.

[DiapDealer]

Yes. A release is based upon a snapshot of the source code at that point in time. Only in the rarest of cases (like a bad build--or an incorrectly signed build--that can be fixed without a change to the source code) would we alter the binaries attached to a release. If it's a critical fix, we would usually just make a new release.

[philja]

I downloaded the latest Sigil.app-2.3.0-1-Mac-arm64.txz on my MacBook Air M2. Double tapped and it unzipped ok. I tapped the app and it opened with Mac's warning about it being a file downloaded from the internet - clicked ok and Sigil opened with a new blank file - as expected.

I was surprised that it was just named Sigil.app. Previous versions contained the version number eg Sigil 2.1.0.app which was useful since I often end up with multiple versions on the Mac.

I then slid the Sigil.app into the applications folder and slid a copy into the dock. That's where my trouble started. Clicking on the icon in the dock appeared to do nothing. The same when I clicked on Sigil.app in the applications directory. Eventually, I noticed a Sigil entry all alone at the top of a new blank screen, next to the Apple logo. Clicking on that icon gave me an invite to open a file. Which I did and it opened correctly. I closed the file ok.

Thereafter, when I tap the icon in the Dock, Sigil opens correctly with a new blank file.

Odd behaviour but maybe it happens in a MacBook?

[KevinH]

No. On MacOS the *unpacked* application is always called "Sigil.app" and nothing else. Perhaps your unpacking routine is wrapping it all in a folder?

Yes after unpacking you should drag and drop the unpacked Sigil.app into your /Applications folder. It will ask you if you want to replace any earlier version.

Then fire up Sigil.app from your Applications folder by double-clicking. Once launched properly you should already see its icon in your dock. You can just drag and drop that running dock icon to a permanent spot in the dock. No need to copy anything.

Sigil.app on macOS is a fully relocatable app. That means you can really rename it as you like (ie add version to name) and move it anyplace you like (not just stay in Applications) but you can NOT have 2 different versions Sigil of the Sigil.app running at the exact same time. You can of course open multiple Main Windows in the one running Sigil.app.

I have many many different versions of Sigil.app stored in different folders on my mac and can run them in place (one ar a time) so that I can debug issues more easily. So keeping older versions around is easy.

And yes you must look at the top menu bar to see if Sigil is still active, and use that top menubar menus to open a file or to CMD-Q to exit out of Sigil completely. Closing the MainWindow will NOT exit out of Sigil.

This ia how multi-main window apps has always worked on macOS (think Microsoft Word, etc ).

[philja]

Originally Posted by KevinH

No. On MacOS the *unpacked* application is always called "Sigil.app" and nothing else. Perhaps your unpacking routine is wrapping it all in a folder?

Yes after unpacking you should drag and drop the unpacked Sigil.app into your /Applications folder. It will ask you if you want to replace any earlier version.

Then fire up Sigil.app from your Applications folder by double-clicking. Once launched properly you should already see its icon in your dock. You can just drag and drop that running dock icon to a permanent spot in the dock. No need to copy anything.

Sigil.app on macOS is a fully relocatable app. That means you can really rename it as you like (ie add version to name) and move it anyplace you like (not just stay in Applications) but you can NOT have 2 different versions Sigil of the Sigil.app running at the exact same time. You can of course open multiple Main Windows in the one running Sigil.app.

I have many many different versions of Sigil.app stored in different folders on my mac and can run them in place (one ar a time) so that I can debug issues more easily. So keeping older versions around is easy.

And yes you must look at the top menu bar to see if Sigil is still active, and use that top menubar menus to open a file or to CMD-Q to exit out of Sigil completely. Closing the MainWindow will NOT exit out of Sigil.

This ia how multi-main window apps has always worked on macOS (think Microsoft Word, etc ).

Thanks for those tips. I'm still learning on Apple (but not necessarily liking) and it was the user guide that told me to drag an app to the Dock.

I have spent a little time trying to understand why I got that new blank window with just Sigil on the menu bar. Because I use Dropbox with several apps, I have a rule never to use the red dot when finished with an app but always to use Quit or Cmd-Q to shut it down. I must have inadvertently clicked red and parked Sigil on that occasion. I can reproduce that behaviour by clicking the red dot so that shouldn't happen again.

[KevinH]

It is just different. The top menubar will show that the last window has closed (ie nothing but the menubar will be shown). But those menus can be used to quit out of the app, or open new documents.

I find it a nice feature because I can launch many apps but not have the screen cluttered until I need that app to do something, and single clicking on the icon can switch between them (ie change the top menubar to whatever app you have activated). I was a longtime MS Office user and constantly had Word, Excel, and PowerPoint open and switching between them with just one screen.

But to each his own.

[philja]

re: Doitsu's warning dialog problem illustrated by his file 'no_doctype_epub3.epub'

I now have Sigil 2.3.0 on my linux box and W10 box and the 2.3.0-1 on the MacBook. Only the MacBook gives the same warning as the illustrations supplied by Doitsu.

The linux and W10 boxes both supply an identical message conveying essentially the same warning but probably an older version.


Sigil on linux was built from source and the W10 version was downloaded and installed normally and replaced earlier versions.

How should I ensure that 'everything' gets upgraded when a new version is built/ installed? Should older config files be destroyed?

[KevinH]

Originally Posted by philja

re: Doitsu's warning dialog problem illustrated by his file 'no_doctype_epub3.epub'

I now have Sigil 2.3.0 on my linux box and W10 box and the 2.3.0-1 on the MacBook. Only the MacBook gives the same warning as the illustrations supplied by Doitsu.

The linux and W10 boxes both supply an identical message conveying essentially the same warning but probably an older version.


Sigil on linux was built from source and the W10 version was downloaded and installed normally and replaced earlier versions.

How should I ensure that 'everything' gets upgraded when a new version is built/ installed? Should older config files be destroyed?

That is very strange... are you sure you built from official github sources for the Sigil 2.3.0 tag?

There were some Beta releases that did not have those fixes but the final released Sigil-2.3.0 certainly had them.

Here is the snippet of code from ImportEPUB.cpp that is in Sigil 2.3.0

    if (autofix) {
            foreach(HTMLResource* htmlres, non_well_formed) {
                QString fixed_text = CleanSource::Mend(htmlres->GetText(),htmlres->GetEpubVersion());
                htmlres->SetText(fixed_text);
            }
            non_well_formed.clear();
            QString warning = tr("This EPUB had HTML files that were not well formed or are "
                   "missing a DOCTYPE, html, head or body elements.<br/><br>They were automatically fixed based on "
                   "your Preference setting to Clean on Open.");
            warning = warning + SEP + problem_files.join("\n");
            AddLoadWarning(warning);
        } else {
            QString warning = tr("This EPUB has HTML files that are not well formed or are "
                   "missing a DOCTYPE, html, head or body elements.<br/></br>Fix these manually or use "
                                 "Sigil's Mend tool to automatically fixed these errors or omissions.");
            warning = warning + SEP + problem_files.join("\n");
            AddLoadWarning(warning);
        }
    }

On Linux, perhaps your distribution version of Sigil (and older one) is being found in your path first? Did you do the sudo make install after make completed?

On Windows could you have an old version being run instead.

What does the About Sigil dialog say on both (exactly). A screen shot of each About box would help.

Typically to build from source you download the source code directly from the Releases page and unpack it and build from there. If you did a git clone earlier to get the source you need to use git to pull in all changes since your prior pull or clone before doing your build.

[BeckyEbook]

@KevinH: If only ONE message is displayed, that's normal, because that's what it means that the latest code from github was used.