[GUI Plugin] Action Chains

[capink]

Originally Posted by ownedbycats

The main thing I noticed is that the "Add Actions" window is initially very tiny and I had to widen it to even be able to see the comments and error columns, but that might be because the settings carried over from the old version.

Yes, it remembers the size from the last time.

Originally Posted by ownedbycats

Personally I'd put "Settings" to the right of "Comment," but that's personal preference. (Making the columns movable would work.)

Maybe sometime in the future. It depends on how difficult is to do it. Never done it before.

Originally Posted by ownedbycats

Column widths reset every time I re-open the dialog. Default width for "Action" column is a bit wide too.

I will see what I can do about this.

[ownedbycats]

By the way, I switched back to "Show Marked Books" and did a few tests. It seems to be behaving for the most part.

[capink]

Originally Posted by ownedbycats

By the way, I switched back to "Show Marked Books" and did a few tests. It seems to be behaving for the most part.

Good to know. If you need an alternative, you can use the selection modifier with the following in the search box:

marked:true

or if you are using your own text for marking

marked:mytext

[capink]

Originally Posted by ownedbycats

Personally I'd put "Settings" to the right of "Comment," but that's personal preference. (Making the columns movable would work.)

Making columns movable turned out to be straightforward. I just set a property and qt takes care of the rest. So, it will be in the next release.

[capink]

from functools import partial

from PyQt5.Qt import (QApplication, Qt)

from calibre.gui2 import error_dialog

from calibre_plugins.action_chains.common_utils import DoubleProgressDialog
from calibre_plugins.action_chains.actions.base import ChainAction

class TrimCover(ChainAction):

    name = 'Trim Cover'
    support_scopes = True

    def trim_covers(self, db, book_ids, pbar):

        from calibre.utils.img import (
            image_from_data, image_to_data, remove_borders_from_image
        )
        
        pbar.update_overall(len(book_ids))
        
        for book_id in book_ids:
            cdata = db.new_api.cover(book_id)
            if cdata:
                img = image_from_data(cdata)
                nimg = remove_borders_from_image(img)
                if nimg is not img:
                    cdata = image_to_data(nimg)
                    db.new_api.set_cover({book_id:cdata})
            msg = _('Trimming cover for book_id: {}'.format(book_id))
            pbar.update_progress(1, msg)

    def run(self, gui, settings, chain):
        db = gui.current_db
        book_ids = chain.scope().get_book_ids()

        callback = partial(self.trim_covers, db, book_ids)
        pd = DoubleProgressDialog(1, callback, gui, window_title=_('Trimming ...'))

        gui.tags_view.blockSignals(True)
        QApplication.setOverrideCursor(Qt.ArrowCursor)
        try:
            pd.exec_()

            pd.thread = None

            if pd.error is not None:
                return error_dialog(gui, _('Failed'),
                        pd.error[0], det_msg=pd.error[1],
                        show=True)
        finally:
            QApplication.restoreOverrideCursor()
            gui.tags_view.recount()

[ownedbycats]

Thank you!

What is the extra (default rightmost) column on the Customize Action Chains window for?

[capink]

Originally Posted by ownedbycats

Thank you!

What is the extra (default rightmost) column on the Customize Action Chains window for?

Right now it is a placeholder because the table is set to stretch the last column to take all the extra space available, so without it you might end up with a very wide settings button.

Can be used in the future for some features I have in mind if necessary (filtering by tags and library availability).

Edit: The customize actions dialog also supports swapping columns, it also saves the last state but only if you press OK, if you press cancel, it does not remember the column state.

[ownedbycats]

I know that JimmXinu had some problems with View Manager and keyboard shortcuts disappearing when switching between libraries, but he put in a pull request to fix that. You should look into that if it's something you plan to implement.

[capink]

Originally Posted by ownedbycats

I know that JimmXinu had some problems with View Manager and keyboard shortcuts disappearing when switching between libraries, but he put in a pull request to fix that. You should look into that if it's something you plan to implement.

I am aware of that, although I have not looked at the code yet. I am not sure if the way to go is to store the config in the library and use Jim's code, or it leave it in the json file as it is now, with and option to control library availability (default is available for all, with an option to turn on/off availability from within every library)

[compurandom]

Presumably you haven't found any library destroying bugs. Would you feel comfortable publishing this plugin in the index yet?

[capink]

Yes. The plan is to ultimately publish this when I feel it has been tested enough without major issues.

Our of curiosity, since you frequent these forums, does it make a difference whether you get it from the thread or the updater?

[compurandom]

Originally Posted by capink

Our of curiosity, since you frequent these forums, does it make a difference whether you get it from the thread or the updater?

It shouldn't, but it does.

[ownedbycats]

The updater is fewer steps.

[Terisa de morgan]

I only want to say thank you for the plugin. I've changed a "small" detail and it's working in calibre 4. It has allowed to simplify a lot of repetitive simple edition, so it has been very useful for me.

[capink]

Originally Posted by Terisa de morgan

I only want to say thank you for the plugin. I've changed a "small" detail and it's working in calibre 4. It has allowed to simplify a lot of repetitive simple edition, so it has been very useful for me.

A pleasure to hear that, you are always welcome.

Open with action would not work with non-ascii paths, this together with my reluctance to test every change on both calibre 4 and 5 lead to it being released under calibre 5 only.

I will try to code in way that keeps it compatible with python2 whenever possible.