Plato: A document reader for PDF, ePUB, DjVu, etc.

[tshering]

Originally Posted by baskerville

Please note that Plato relies on /tmp/nickel-hardware-status for knowing when the USB cable is plugged. KSM changes /usr/local/Kobo/udev/plug and prevents it from writing to the aforementioned FIFO. I'll suggest a different approach to tshering when he returns.

I think I will simply replace

[ "$(pidof nickel | wc -w)" == "0" ] && exit

by

[ "$(pidof nickel | wc -w)" == "0" ] || [ "$(pidof plato | wc -w)" == "0" ] && exit

in plug. What do you think?
Should I tread plato the same way as nickel in /usr/local/Kobo/udev/sd too?

Originally Posted by baskerville

I forgot to mention that the wifi-{enable,disable}.sh scripts won't work when Plato is launched via KSM: the required environment variables are defined late in rcS and KSM starts early.

Actually these variables are available when KSM is running. Your script does work, when on inserts " sleep 2" after

insmod "$WIFI_MODULE_PATH"

As for plato.sh, if you run "./nickel.sh &" only if nickel was running before you launched plato, KSM could simply call this plato.sh. Then I would not need to change my calling script each time you change plato.sh.

[baskerville]

Originally Posted by tshering

I think I will simply replace

[ "$(pidof nickel | wc -w)" == "0" ] && exit

by

[ "$(pidof nickel | wc -w)" == "0" ] || [ "$(pidof plato | wc -w)" == "0" ] && exit

in plug. What do you think?

Well, you could write this as

pidof nickel plato > /dev/null || exit

.

But I had something else in mind:
- Don't change any script in /usr/local/Kobo/udev/.
- Use the following function:

toggle_nickel_hardware_status() {
	local fifo_path=/tmp/nickel-hardware-status
	local arg=$1
	if [ "$arg" == on ] ; then
		while [ ! -p "$fifo_path" ] ; do
			rm "$fifo_path"
			mkfifo "$fifo_path"
		done
	elif [ "$arg" == off ] ; then
		while [ ! -L "$fifo_path" ] ; do
			rm "$fifo_path"
			ln -s /dev/null "$fifo_path"
		done
	else
		printf "toggle_nickel_hardware_status: invalid argument: '%s'." "$arg" >2
	fi
}

to change the nature of /tmp/nickel-hardware-status.

Originally Posted by tshering

Actually these variables are available when KSM is running.

My bad.

Originally Posted by tshering

Your script does work, when on inserts " sleep 2" after

insmod "$WIFI_MODULE_PATH"

The ommision of the sleep statements is intentional: when the last insmod ... returns, /sys/class/net/${INTERFACE} already exists. Do you know why the sleep statement was introduced?

Originally Posted by tshering

As for plato.sh, if you run "./nickel.sh &" only if nickel was running before you launched plato, KSM could simply call this plato.sh. Then I would not need to change my calling script each time you change plato.sh.

I'll amend the script accordingly.

[tshering]

Originally Posted by baskerville

Well, you could write this as

pidof nickel plato > /dev/null || exit

.

This is much better than mine.

Originally Posted by baskerville

The ommision of the sleep statements is intentional: when the last insmod ... returns, /sys/class/net/${INTERFACE} already exists. Do you know why the sleep statement was introduced?

Without the sleep statement before ifconfig eth0 up "sh -x /mnt/onboard/.adds/plato/scripts/wifi-enable.sh" gives me

+ lsmod
+ grep -q sdio_wifi_pwr
+ insmod /drivers/mx50-ntx/wifi/sdio_wifi_pwr.ko
+ insmod /drivers/mx50-ntx/wifi/dhd.ko
+ ifconfig eth0 up
ifconfig: SIOCGIFFLAGS: No such device
+ wlarm_le -i eth0 up
wlarm_le: wl driver adapter not found
+ pidof wpa_supplicant
+ wpa_supplicant -D wext -s -i eth0 -c /etc/wpa_supplicant/wpa_supplicant.conf -C /var/run/wpa_supplicant -B
+ udhcpc -S -i eth0 -s /etc/udhcpc.d/default.script -t15 -T10 -A3 -b -q
udhcpc: SIOCGIFINDEX: No such device

, but with sleep 2, it works.

[baskerville]

Originally Posted by tshering

+ ifconfig eth0 up
ifconfig: SIOCGIFFLAGS: No such device

Does it work if you add:

while [ ! -e /sys/class/net/${INTERFACE} ] ; do
	sleep 0.1
done

before ifconfig eth0 up?

[tshering]

Originally Posted by baskerville

Does it work if you add:

while [ ! -e /sys/class/net/${INTERFACE} ] ; do
	sleep 0.1
done

before ifconfig eth0 up?

Yes, it does. On my device after 6 loops. I will take this approach too.

[baskerville]

I've released 0.3.1.

The installation instructions have changed slightly: there's one archive for the program and its support files, and one archive for each launcher.

@tshering: Is the script packaged in plato-launcher-ksm-0.3.1.zip ok?

[tshering]

Originally Posted by baskerville

@tshering: Is the script packaged in plato-launcher-ksm-0.3.1.zip ok?

I was thinking of something like:

Spoiler:

#! /bin/sh

WORKDIR=$(dirname "$0")
cd "$WORKDIR" || exit 1

if pidof nickel; then
  FROMNICKEL=true
  eval "$(xargs -n 1 -0 < /proc/$(pidof nickel)/environ | sed -e 's/^/export /')"
  sync
  killall nickel hindenburg sickel fickel fmon > /dev/null 2>&1
else
  FROMNICKEL=false
fi

export LD_LIBRARY_PATH="libs:${LD_LIBRARY_PATH}"

./plato > info.log 2>&1 || mv info.log crash.log

if [ "${FROMNICKEL}" == "true" ]; then
  ./nickel.sh &
fi

so that you have to distribute only one version. KSM would call it with a wrapper script like this

Spoiler:

#! /bin/sh

# todo: set rotation value for the different device models
# currently I know only for sure that trilogy|kraken|alyssum|daylight need 3
case $PRODUCT in
  trilogy|kraken|alyssum|daylight ) platoRotation="3";;
  * ) platoRotation="3";;
esac

currentRotation=$(cat /sys/class/graphics/fb0/rotate)
echo "${platoRotation}" > /sys/class/graphics/fb0/rotate
cat /sys/class/graphics/fb0/rotate > /sys/class/graphics/fb0/rotate


# todo: maybe warn when wifi is on?

${platobasedir}/plato.sh
# alternatively
#cd "${platobasedir}" || exit 1
#export LD_LIBRARY_PATH="libs:${LD_LIBRARY_PATH}"
#./plato > info.log 2>&1 || mv info.log crash.log


echo "${currentRotation}" > /sys/class/graphics/fb0/rotate
cat /sys/class/graphics/fb0/rotate > /sys/class/graphics/fb0/rotate

# todo: maybe warn when wifi is on?

note: the line

cat /sys/class/graphics/fb0/rotate > /sys/class/graphics/fb0/rotate

is needed for some models (Aura HD, H2O, H2O2, if I remember correctly).

Are you certain that 3 is the correct rotate value for all models?

[tshering]

On Kobo Glo, the menu (sandwich symbol) does not work. It registers the touch (becomes dark for a moment, but the menu does not open. It works however on the Kobo Touch (C).

[baskerville]

I've ran top and noticed that the plato process is using 99% CPU in idle state. Don't use Plato until further notice!

[baskerville]

Fortunately, I found the source of the problem quickly: reading from /tmp/nickel-hardware-status!

I will therefore drop the current approach (unless someone has an idea on how to properly poll the FIFO) and write something similar to libue instead.

The problem exists since version 0.2.0.

[tshering]

Originally Posted by baskerville

I've ran top and noticed that the plato process is using 99% CPU in idle state. Don't use Plato until further notice!

Are you sure that there is a problem? I see 99.x% idle most of the time with plato running, falling to 86% idle while opening large books. Isn't this a good value?

[baskerville]

Originally Posted by tshering

Isn't this a good value?

No it isn't (it should be about 0 %).

But I was able to fix the problem in e89d090 and will make a release soon.

[baskerville]

I've released 0.3.2.

This version fixes the CPU hog problem!

[baskerville]

Originally Posted by tshering

I was thinking of something like:

Spoiler:

#! /bin/sh

WORKDIR=$(dirname "$0")
cd "$WORKDIR" || exit 1

if pidof nickel; then
  FROMNICKEL=true
  eval "$(xargs -n 1 -0 < /proc/$(pidof nickel)/environ | sed -e 's/^/export /')"
  sync
  killall nickel hindenburg sickel fickel fmon > /dev/null 2>&1
else
  FROMNICKEL=false
fi

export LD_LIBRARY_PATH="libs:${LD_LIBRARY_PATH}"

./plato > info.log 2>&1 || mv info.log crash.log

if [ "${FROMNICKEL}" == "true" ]; then
  ./nickel.sh &
fi

so that you have to distribute only one version. KSM would call it with a wrapper script like this

Spoiler:

#! /bin/sh

# todo: set rotation value for the different device models
# currently I know only for sure that trilogy|kraken|alyssum|daylight need 3
case $PRODUCT in
  trilogy|kraken|alyssum|daylight ) platoRotation="3";;
  * ) platoRotation="3";;
esac

currentRotation=$(cat /sys/class/graphics/fb0/rotate)
echo "${platoRotation}" > /sys/class/graphics/fb0/rotate
cat /sys/class/graphics/fb0/rotate > /sys/class/graphics/fb0/rotate

# todo: maybe warn when wifi is on?

${platobasedir}/plato.sh
# alternatively
#cd "${platobasedir}" || exit 1
#export LD_LIBRARY_PATH="libs:${LD_LIBRARY_PATH}"
#./plato > info.log 2>&1 || mv info.log crash.log

echo "${currentRotation}" > /sys/class/graphics/fb0/rotate
cat /sys/class/graphics/fb0/rotate > /sys/class/graphics/fb0/rotate

# todo: maybe warn when wifi is on?

note: the line

cat /sys/class/graphics/fb0/rotate > /sys/class/graphics/fb0/rotate

is needed for some models (Aura HD, H2O, H2O2, if I remember correctly).

I prefer to have one script and some support files (fmon requires icons/plato.png but KSM doesn't) for each launcher.

Originally Posted by tshering

Are you certain that 3 is the correct rotate value for all models?

I'm not.

[baskerville]

Originally Posted by tshering

On Kobo Glo, the menu (sandwich symbol) does not work. It registers the touch (becomes dark for a moment, but the menu does not open. It works however on the Kobo Touch (C).

Is there anything out of the ordinary in info.log?

Can you open the Sort by: … menu? or the frontlight dialog?

Can you toggle the frontlight by holding your finger on the frontlight icon?