03-25-2024, 01:57 PM | #46 |
Connoisseur
Posts: 62
Karma: 10
Join Date: Mar 2024
Device: none
|
Oh I AM, but I'm also very open for easy shortcuts!
|
03-25-2024, 02:29 PM | #47 |
Connoisseur
Posts: 62
Karma: 10
Join Date: Mar 2024
Device: none
|
Making progress...
|
Advert | |
|
03-25-2024, 02:43 PM | #48 |
Sigil Developer
Posts: 8,109
Karma: 5450184
Join Date: Nov 2009
Device: many
|
Looks good!
I can do that with no changes with both clip bar 1 and clip bar 2, resized and placed side by side. If you do get something fully working on all platforms and it takes up no more extra vertical space (as height is the key constraint on a monitor - not width), we would be happy to review those changes as a pull request for merging into Sigil. Last edited by KevinH; 03-25-2024 at 02:48 PM. |
03-25-2024, 02:52 PM | #49 |
Connoisseur
Posts: 62
Karma: 10
Join Date: Mar 2024
Device: none
|
I can get up to 40 clips on toolbar 1, but from clip41 nothing's showing on toolbar 2. Is there logic somewhere that I need to change?
|
03-25-2024, 03:18 PM | #50 |
Sigil Developer
Posts: 8,109
Karma: 5450184
Join Date: Nov 2009
Device: many
|
Yes in MainWindow.cpp It is what connects the actions defined in main.ui.
So make sure you have added new clip actions in main.ui first before moving to MainWindow.cpp. Try searching there for "clip" and one of the clip actions to see where changes might be needed as MainWindow.cpp is huge. |
Advert | |
|
03-25-2024, 03:42 PM | #51 |
Guru
Posts: 771
Karma: 2297170
Join Date: Jan 2017
Location: Poland
Device: Various
|
Yes. Add actionClip41 to actionClip80.
File \Form_Files\main.ui is crucial. |
03-25-2024, 04:01 PM | #52 |
Connoisseur
Posts: 62
Karma: 10
Join Date: Mar 2024
Device: none
|
|
03-25-2024, 05:02 PM | #53 |
Guru
Posts: 771
Karma: 2297170
Join Date: Jan 2017
Location: Poland
Device: Various
|
This is not enough.
The third place is just as important (you're sure to track it down, look for "Insert Clip 40"): Spoiler:
|
03-25-2024, 05:06 PM | #54 |
Sigil Developer
Posts: 8,109
Karma: 5450184
Join Date: Nov 2009
Device: many
|
Hmm ... I took a look at the MainWindow.cpp code and DiapDealer has greatly improved that code that handles clip actions to only depend on how many actions are defined in the main.ui, and even added a lambda function to assign slots.
That should take care of everything for MainWindow.cpp unless I am missing something (it has been a few years since I studied this code). Are you sure you have assigned 40 actions to clip toolbar 1, and 40 newly defined actions to clip toolbar 2 in main.ui. Along with the changes to handling clip actions made by DiapDealer that really should get you close. BeckyEbook's spoiler hint is correct. You need to actually define what actions 41-80 are. Then assign them all to the second clips bar and the second clips menu. Last edited by KevinH; 03-25-2024 at 05:14 PM. |
03-25-2024, 05:29 PM | #55 |
Connoisseur
Posts: 62
Karma: 10
Join Date: Mar 2024
Device: none
|
Thank you, found it.
Looking better now. |
03-25-2024, 07:13 PM | #56 |
Sigil Developer
Posts: 8,109
Karma: 5450184
Join Date: Nov 2009
Device: many
|
Nicely done!
What happens if you now go to Sigil Preferences and grow the Icon size? Will the toolbars properly adjust and will you get the scroll indicator at the end of the toolbar? Does the scroll indicator at the end of the clip toolbar, interfere with using the clips at all? |
03-25-2024, 07:39 PM | #57 |
Guru
Posts: 771
Karma: 2297170
Join Date: Jan 2017
Location: Poland
Device: Various
|
The scroll indicator appears at the end of the bar. The bar expands downwards, obscuring a possible bar below. Selecting items once the bar has expanded is not easy, as you cannot go beyond the Clips Toolbar as you will lose the 'hover' and the bar will return to its default (shorter) state. But with the right toolbar layout, you can get used to it.
The scroll indicator is visible in the default light theme, but in dark mode it is not visible until you hover over it. I will try to track this down and find a solution. |
03-25-2024, 10:05 PM | #58 | |
Sigil Developer
Posts: 8,109
Karma: 5450184
Join Date: Nov 2009
Device: many
|
Quote:
I do not see a dark mode issue on macOS. |
|
03-26-2024, 12:58 AM | #59 |
Connoisseur
Posts: 62
Karma: 10
Join Date: Mar 2024
Device: none
|
This is what it looks like when I set the icon size to maximum
|
03-26-2024, 07:32 AM | #60 |
Sigil Developer
Posts: 8,109
Karma: 5450184
Join Date: Nov 2009
Device: many
|
Nice, since text, the clips icons are not growing.
What happens if you change the ui font size in Sigil Preferences to be bigger? |
|
Similar Threads | ||||
Thread | Thread Starter | Forum | Replies | Last Post |
Feature request | jlynton | KOReader | 12 | 09-15-2019 04:43 AM |
Feature Request | galaxyhub | Sigil | 3 | 07-22-2019 01:47 PM |
Feature Request? | RobSys52 | Library Management | 4 | 03-12-2019 04:34 AM |
Feature request: | oilwood | Calibre | 5 | 11-08-2010 02:59 PM |
Feature request | AprilHare | EPUBReader | 2 | 11-22-2009 05:15 AM |