[GUI Plugin] EpubMerge

[thiago.eec]

Originally Posted by theducks

There is another reason that Jimm's idea is best:
The icons IN the plugin are default and the fallback.
whereas the Resources are User supplied

Yes, and I'm not suggesting to change that. That is the default behavior.
I think you misunderstood my post.

[JimmXinu]

New Test Version Posted

2022-07-19
- Look for icon.png without images/ first.

FYI, I'm not sure this is going to be the final solution.

In Cal6, the get_icons(icon_name,plugin_name) does retrieval from resources/images, from a theme and then, if not in either, retrieval from the plugin zip.

In past, the plugin code removed the 'images/' before looking in resources/images for custom icons, but kept it for looking inside the plugin zip.

Moving the icon.png up from the images/ dir inside the plugin zip didn't work when I tried it in Cal5. As I recall, there were reasons it was in images/, but I don't remember why exactly.

Regardless, it would require retesting on the all supported old versions of Calibre, in all the plugins I support. I'm not doing that, sorry.

This appears to work as expected:

...
        if not icon or icon.isNull():
            icon = get_icons(icon_name.replace('images/',''),plugin_name)
        if not icon or icon.isNull():
            icon = get_icons(icon_name,plugin_name)
    return icon

Except that Cal6 explicitly reports not finding 'icon.png' (without images/) all the time in the debug log if it's not found in resources/images or theme (we know it's not to be found in plugin zip):

Traceback (most recent call last):
  File "C:\Users\user\Desktop\nook\calibre\src\calibre\customize\zipplugin.py", line 50, in get_resources
  File "zipfile.py", line 1464, in read
  File "zipfile.py", line 1503, in open
  File "zipfile.py", line 1430, in getinfo
KeyError: "There is no item named 'icon.png' in the archive"

It's not raising the exception, it's just printing the stack trace to debug.

But it happens quite a bit, and I run calibre in debug 99.9% of the time.

I could cache icons in the plugin, but then they wouldn't change if you change themes. Which isn't something that works consistently for me anyway?

[kovidgoyal]

https://github.com/kovidgoyal/calibr...41ede054db0e34

You will of course need to version check before using the new parameter.

[JimmXinu]

Thanks.

I will post plugin test version(s) that use this after Calibre 6.2 comes out.

[JimmXinu]

New Test Version Posted

2022-07-30
- Use cal6 icon theme system to allow plugin icon customization--but don't require pluginname/images/

Should work correctly now with new icon theme system and old system and internal images without reporting extra errors (cal6.2+).

Originally Posted by JimmXinu

New Test Version Posted
...

thiago.eec, I'd appreciate it if you'd confirm if this solves the issue for you; thanks.

[thiago.eec]

Originally Posted by JimmXinu

New Test Version Posted
thiago.eec, I'd appreciate it if you'd confirm if this solves the issue for you; thanks.

Hi, @JimmXinu

It works fine here. Thanks!

[JimmXinu]

New Version Released

Version 2.14.0 - 2022-07-31
- Use Cal6 get_icons() so icon themes apply
- Update Translations

[JimmXinu]

New Test Version

2022-09-09

- Fix remove/up/down rows when lower selected first.

Issue found in Reading List.

[JimmXinu]

New Version Released

Version 2.15.0 - 2022-09-13
- Fix remove/up/down rows when lower selected first.
- Update Translations

[Geremia]

Is there a way to use this plugin from the command-line, without having to import the EPUBs into Calibre?

[JimmXinu]

Originally Posted by Geremia

Is there a way to use this plugin from the command-line, without having to import the EPUBs into Calibre?

There are two ways:

1. If you go back to the first post of this thread, there's a section on "Command Line Interface(CLI)" about how to call the plugin's basic functionality from the version installed in Calibre.
   
   This version is intended for users who have Calibre installed and want to use EpubMerge from CLI without needing Python installed.
   
2. If, OTOH, you have Python but don't normally have Calibre installed, you visit the EpubMerge github project page where you can download the epubmerge.py file and run it directly. You will also need the python library 'six' installed.

I've never gotten around to doing a 'proper' pypi CLI release of EpubMerge; there's an issue about it and everything.

[Elizebeth Janell]

I recently found your plug-in, and it works great. My question is : can I remove the original files the anthology makes up from Calibre to free up the space on my booklist ?

[JimmXinu]

Yes.

The merged copy does not depend on the source epubs. In fact, if you have the EpubMerge config option "Keep UnMerge Metadata" checked (it is checked by default), you can even UnMerge the new epub to get the original epubs back again.

[Mandabar]

Oh hey, It's you again Jimm~!

You make all the best plugins, you are just the best!

On to my question. Is there a way to configure the plugin to have it rename the stylesheets and other merged files? I think it's a quirk of my android epub reader app (Moon+ Reader Pro) that it doesn't handle same-name files in different folders very well. It works fine if I manually edit them in calibre's editor to rename all the covers, stylesheets, and pagestyles so they aren't the same (sequential numbering or whatever). Otherwise it just keeps reusing the first instance.

Just double-checking since I don't see an option that jumps out at me as being for this and it's not the largest of hardships to manually batch rename my occasional epubmerge.

[JimmXinu]

No.

Changing file names also requires finding and changing all the references to those files in other files and EpubMerge just isn't that smart.

It's an issue that's come up before with Sigil.