![]() |
#31 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 6,328
Karma: 12117215
Join Date: Jun 2009
Location: Madrid, Spain
Device: Kobo Clara/Aura One/Forma,XiaoMI 5, iPad, Huawei MediaPad, YotaPhone 2
|
Yes, exactly that. I've seen a couple of patches with that comment, and some in nickel have the same recommendation
|
![]() |
![]() |
![]() |
#32 |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 2,788
Karma: 6990707
Join Date: May 2016
Location: Ontario, Canada
Device: Kobo Mini, Aura Edition 2 v1, Clara HD
|
Boriar's idea would be good except that I want to maintain as much compatibility as possible with the original patcher, at least for now.
The way I would probably do it is if two patches have the same name (minus part n of n) and one is enabled, the other would automatically be enabled as well. |
![]() |
![]() |
Advert | |
|
![]() |
#33 |
Zealot
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 105
Karma: 37418
Join Date: Jan 2013
Device: Kobo Glo, Aura, H2OE2, Libra 2
|
When I first tried this new patching system I had problems with the error: patch_group should not be a comment.
I was using the patches as published by GeoffR which in some cases have the commented line "# patch_group = " After removing the comment marker (#), from these "patch_group=" lines, the patch progressed ok. Bit of a pain going through the patches and editing the problem lines rather spoils using the nice kobopatch.yaml feature. I assume this is a temporary glich. Once the files had been patched I compared them with those from the original patcher and they where reported as being identical. ![]() ![]() |
![]() |
![]() |
![]() |
#34 | |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 2,788
Karma: 6990707
Join Date: May 2016
Location: Ontario, Canada
Device: Kobo Mini, Aura Edition 2 v1, Clara HD
|
Quote:
Yep. Thanks for trying it out! As for the error, that is supposed to happen, as the old patcher did not support the patch_group instruction, so it was commented out. My automated conversion tool fixes that for all the default patches, but for individual patches, you'll need to do it manually. |
|
![]() |
![]() |
![]() |
#35 |
Zealot
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 105
Karma: 37418
Join Date: Jan 2013
Device: Kobo Glo, Aura, H2OE2, Libra 2
|
I'm sure you know best. But to me, it just seems wrong not to ignore a commented out command.
|
![]() |
![]() |
Advert | |
|
![]() |
#36 |
Resident Curmudgeon
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 75,774
Karma: 134321338
Join Date: Nov 2006
Location: Roslindale, Massachusetts
Device: Kobo Libra 2, Kobo Aura H2O, PRS-650, PRS-T1, nook STR, PW3
|
If this new patching system cannot handle allowing us to change things, then it's of no use. I do make some changes to fit my needs. If I cannot do this, then I prefer to stick to the current system until such times as this can be fixed to allow changes to be made.
|
![]() |
![]() |
![]() |
#37 | |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 6,328
Karma: 12117215
Join Date: Jun 2009
Location: Madrid, Spain
Device: Kobo Clara/Aura One/Forma,XiaoMI 5, iPad, Huawei MediaPad, YotaPhone 2
|
Quote:
|
|
![]() |
![]() |
![]() |
#38 | |||
Resident Curmudgeon
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 75,774
Karma: 134321338
Join Date: Nov 2006
Location: Roslindale, Massachusetts
Device: Kobo Libra 2, Kobo Aura H2O, PRS-650, PRS-T1, nook STR, PW3
|
Quote:
Quote:
Quote:
|
|||
![]() |
![]() |
![]() |
#39 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 6,328
Karma: 12117215
Join Date: Jun 2009
Location: Madrid, Spain
Device: Kobo Clara/Aura One/Forma,XiaoMI 5, iPad, Huawei MediaPad, YotaPhone 2
|
To me, it reads as the tool is not going to handle customization, in the same way that the current tool doesn't handle it either. And no, the current tool doesn't handle it, you have to modify the patch, and in the same way you can do it here (I've done it).
|
![]() |
![]() |
![]() |
#40 | |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 2,788
Karma: 6990707
Join Date: May 2016
Location: Ontario, Canada
Device: Kobo Mini, Aura Edition 2 v1, Clara HD
|
Quote:
I'm sorry about the misunderstanding. What is happening is my patching system currently does everything the old one does, and more. What they want is to be able to find and replace instructions from the main config file (not the patch files) to make it easier to upgrade versions. I'm saying it would make validation of the actual patch files harder if the patch can be modified from more than one location. You can still modify the patch files manually and do more than you could with the old patching system. Hope this clears things up. ![]() |
|
![]() |
![]() |
![]() |
#41 | |
Guru
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 869
Karma: 2676800
Join Date: Aug 2008
Location: Taranaki - NZ
Device: Kobo Aura H2O, Kobo Forma
|
Quote:
geek1011 is correct in that GeoffR's patcher never used it. |
|
![]() |
![]() |
![]() |
#42 | |
Evangelist
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 407
Karma: 314204
Join Date: Jan 2015
Device: bq Avant XL, Kobo Aura H2O, Onyx Boox M96C Plus
|
Quote:
![]() |
|
![]() |
![]() |
![]() |
#43 | |
Evangelist
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 432
Karma: 2303460
Join Date: Aug 2017
Device: Pocketbook Inkpad 3, Onyx T76ML, Kobo H2O Edition 1, Kobo Mini
|
I'm trying to use it in Linux, but I get the following error:
Quote:
|
|
![]() |
![]() |
![]() |
#44 |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 2,788
Karma: 6990707
Join Date: May 2016
Location: Ontario, Canada
Device: Kobo Mini, Aura Edition 2 v1, Clara HD
|
|
![]() |
![]() |
![]() |
#45 | |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 2,788
Karma: 6990707
Join Date: May 2016
Location: Ontario, Canada
Device: Kobo Mini, Aura Edition 2 v1, Clara HD
|
Quote:
Also, I might write a GUI for kobopatch if nobody else wants to and there is enough demand for it. |
|
![]() |
![]() |
![]() |
Tags |
kobo, kobopatch, patch, patch32lsb |
|
![]() |
||||
Thread | Thread Starter | Forum | Replies | Last Post |
kobopatch - A new (WIP) patching system | geek1011 | Kobo Developer's Corner | 93 | 05-27-2018 03:04 PM |
Patching H2O | Maillemom | Kobo Developer's Corner | 8 | 10-19-2016 09:58 AM |
Instructions for patching firmware 3.17.3 | GeoffR | Kobo Developer's Corner | 60 | 09-17-2015 05:35 PM |
Instructions for patching firmware 3.8.0 | GeoffR | Kobo Developer's Corner | 92 | 10-22-2014 07:22 AM |
how to clean more disk space in root file system to upgrade system | chinaet | iRex | 1 | 12-18-2006 03:54 PM |