![]() |
#31 | |
Sigil Developer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 7,957
Karma: 5449552
Join Date: Nov 2009
Device: many
|
Hi BeckyEbook
Thank you! I already found your FindReplace font family and size one and added it to the new Advanced Topics chapter but will add the others. Quote:
|
|
![]() |
![]() |
![]() |
#32 | |
null operator (he/him)
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 20,805
Karma: 27405122
Join Date: Mar 2012
Location: Sydney Australia
Device: none
|
Quote:
I really like the extra/repositioned dock zones above Codeview and to the left of Preview. BR |
|
![]() |
![]() |
Advert | |
|
![]() |
#33 | |
Sigil Developer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 7,957
Karma: 5449552
Join Date: Nov 2009
Device: many
|
Yes that change was added to help older ADE ereaders deal with covers. It was made since the last version of the users guide so please update it.
Quote:
|
|
![]() |
![]() |
![]() |
#34 |
Guru
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 733
Karma: 2296998
Join Date: Jan 2017
Location: Poland
Device: Various
|
BTW,
While testing version 2.3.0 (beta2) on Windows, I think I see a bug. With "User Classic Sigil Dark Theme" enabled, the two close/undock images are very tiny. |
![]() |
![]() |
![]() |
#35 | |
Sigil Developer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 7,957
Karma: 5449552
Join Date: Nov 2009
Device: many
|
Quote:
Which gives us the following: QDockWidget::float-button, QDockWidget::close-button { border: transparent; background: transparent; padding: 0; icon-size: 9px; } QDockWidget { titlebar-normal-icon: url(:/dark/undock.svg); titlebar-close-icon: url(':/dark/dock-close.svg'); } The ones when the native qt dark mode for windows are set by qss in main.cpp : const QString LINWIN_DOCK_TITLEBAR_FIX = "QDockWidget { " " titlebar-close-icon: url(:/dark/dock-close.svg);" " titlebar-normal-icon: url(:/dark/undock.svg);" "}"; So both dark themes use the exact same svg images. But the classic dark theme uses smaller dock titlebar icons because of qss icon-size. But that code is over 5 years old and I think you wrote it or helped write it, correct? Last edited by KevinH; 08-11-2024 at 09:40 PM. |
|
![]() |
![]() |
Advert | |
|
![]() |
#36 |
Guru
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 733
Karma: 2296998
Join Date: Jan 2017
Location: Poland
Device: Various
|
Indeed.
In beta1 (July 7) the problem also occurred. I need to check it more thoroughly. I also switched to Qt 6.7.2, and there is probably a hidden reason for this strange behavior somewhere. I will try to investigate it. |
![]() |
![]() |
![]() |
#37 |
Sigil Developer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 7,957
Karma: 5449552
Join Date: Nov 2009
Device: many
|
We could always increase the win-dark-style.qss icon-size of 9px for QDockWidget Icons in the classic dark theme to make it bigger, but I wonder what in Qt6 changed that requires we change it. Perhaps a bug fix in Qt or Qt6 removal of the highdpi for Windows?
|
![]() |
![]() |
![]() |
#38 |
Guru
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 733
Karma: 2296998
Join Date: Jan 2017
Location: Poland
Device: Various
|
Just change to 16px.
I also thought of something related to HighDPI, so you can: a) do nothing (any user can fix it for themselves via qss) b) however, change it to 16px c) wait for the posts of other beta2 users on Windows, whether they see tiny icons and whether adding code to qss improves the situation: Code:
QDockWidget::float-button, QDockWidget::close-button { icon-size: 16px; } |
![]() |
![]() |
![]() |
#39 | |
null operator (he/him)
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 20,805
Karma: 27405122
Join Date: Mar 2012
Location: Sydney Australia
Device: none
|
Quote:
![]() BR |
|
![]() |
![]() |
![]() |
#40 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 27,784
Karma: 198099188
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
I would rather let users tweak the dock close icon sizes themselves on Windows (with qss). They don't look tiny on my Windows machines (one laptop and one virtual) and I dislike the notion of hard coding sizes.
I used our pre-exising dark icons to fix Qt's broken hardcoded xpm ones (they look horrible with dark themes), but that's about as far as I'd like to go down the rabbit hole of trying to "fix" the inherent Qt6.5+ fusion dark theme's inadequacies on Windows for everyone. Nothing is going to work for everyone's dpi and/or fractional scaling settings. Never mind: I just noticed that this is with our Classic dark theme. My bad. Perhaps we simply remove the 9 pixel qss from SigilDarKTheme in Qt6.7+? It seems to work Ok in the inherent dark theme without any pixel size specifications. Last edited by DiapDealer; 08-12-2024 at 06:39 AM. |
![]() |
![]() |
![]() |
#41 |
Guru
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 733
Karma: 2296998
Join Date: Jan 2017
Location: Poland
Device: Various
|
Great idea.
I removed the font-size from win-dark-style.qss and built Sigil. Everything is fine. If I remember correctly Qt5 required this entry, because otherwise it didn't work. @KevinH: So you can add this entry in QSS for those who want close and undock icons larger or smaller for the Advanced Topics chapter. Upon reflection: I think Qt6 fixed a bug with Qt5, because since the font-size entry was not needed it is now just "normal". |
![]() |
![]() |
![]() |
#42 | |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 27,784
Karma: 198099188
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
Quote:
I was actually able to see the tiny icon size on my Windows machines after all. So something definitely seems to have changed with Qt6.7. I did most of my Windows dual-dark-theme work when we were still on Qt6.6.3 and didn't notice anything (and believe me--I was looking! ![]() I'm not going to try to ifdef its application to 6.7+ or anything, because: 1) it's Windows-only and we're shipping the Windows installer with Qt6.7.2; and 2) the .qss solution is always available if it does happen to manifest with other versions of home-built Windows Sigil. |
|
![]() |
![]() |
![]() |
#43 |
Sigil Developer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 7,957
Karma: 5449552
Join Date: Nov 2009
Device: many
|
I have now pushed that change - remove hard coded icon size in classic dark mode to Sigil master.
I will add the qss code to change the size to the Advanced Topics chapter in the sigil-user-guide. (update - now added) Last edited by KevinH; 08-12-2024 at 09:37 AM. |
![]() |
![]() |
![]() |
#44 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 27,784
Karma: 198099188
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
I did the same for the inspector dockwidget in PageEdit.
|
![]() |
![]() |
![]() |
#45 |
Sigil Developer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 7,957
Karma: 5449552
Join Date: Nov 2009
Device: many
|
I am going to update the base.ts one more time because of a tooltip change and line number changes, then I would say we are in good shape for 2.3.0.
The user guide, once odamizu's changes are in place, will be in a good place too. Thanks to all that helped with the user-guide and with testing both Beta 1 and Beta 2. |
![]() |
![]() |
![]() |
|
![]() |
||||
Thread | Thread Starter | Forum | Replies | Last Post |
Wanted: Volunteers to Update the Sigil User's Guide | KevinH | Sigil | 55 | 05-18-2018 02:52 AM |
Finding your most recent Users’ Guide | seanyyz | Amazon Kindle | 1 | 01-21-2018 01:26 PM |
Content New KindleWiFi Users' Guide | sirmaru | Amazon Kindle | 2 | 09-19-2010 12:27 AM |
K2 PDF Users Guide Sillyness | JSWolf | Amazon Kindle | 5 | 02-10-2009 04:11 PM |
Can I delete Kindle Users Guide? | KlondikeGeoff | Amazon Kindle | 4 | 12-15-2008 06:26 PM |