Koreader Highlights utility

[pazos]

Hey @embryo, any plans to make this tool compatible with other OSes? (linux, mac). It shouldn't be too hard to make it work. I don't mean packaging, just running the script with system-wide installed pyside (via pip3).

Thanks for your time!

[Frenzie]

Looks like the dependency isn't Python 3-compatible:

KoHighlights-0.5.0.0$ python3 main.py 
Traceback (most recent call last):
  File "main.py", line 17, in <module>
    from slppu import slppu as lua  # https://github.com/noembryo/slppu
  File "/home/frans/src/kobo/KoHighlights-0.5.0.0/slppu.py", line 131
    print ERRORS['unexp_end_string']
               ^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print(ERRORS['unexp_end_string'])?

But other than that APPDATA thing I suspect it might pretty much just work as is.

Edit: yup, works fine.

Edit 2: except for this when double clicking on a book since os.startfile() is apparently Windows-only:

$ python main.py 
Traceback (most recent call last):
  File "main.py", line 377, in on_file_table_itemDoubleClicked
    (os.startfile(path) if isfile(path) else
AttributeError: 'module' object has no attribute 'startfile'

You can easily make it a little more generic using something like this (via):

import os, sys, subprocess

def open_file(filename):
    if sys.platform == "win32":
        os.startfile(filename)
    else:
        opener ="open" if sys.platform == "darwin" else "xdg-open"
        subprocess.call([opener, filename])

[embryo]

@Frenzie Thank you for testing..

I've made the slppu.py python 3.x compatible and also added the function to open the books on other OSes.

What do you mean by "the APPDATA thing"?
EDIT: Ah, you meant the os.environ["APPDATA"] that is used for the SETTINGS_DIR variable...
How about using this:

if sys.platform == "win32":  # Windows
    SETTINGS_DIR = join(os.environ["APPDATA"], APP_NAME)
elif sys.platform == "darwin":  # MacOS
    SETTINGS_DIR = join(os.path.expanduser("~"), "Library",
                        "Application Support", APP_NAME)
else:  # Linux
    SETTINGS_DIR = join(os.path.expanduser("~"), "." + APP_NAME)

I will upload the changes to github but not compile the 0.6. version yet, since I'm waiting for other KoReader changes (hint-hint ;o)

[Frenzie]

Apologies, it's what's keeping the program from starting on non-Windows operating systems. I'm talking about this line.

On Linux and Mac that's HOME followed by some stuff (different on both platforms I'm afraid, though HOME would suffice as a rather dumb implementation).

There's a module that abstracts it away for you if desired: https://pypi.org/project/appdirs/

[embryo]

Originally Posted by Frenzie

There's a module that abstracts it away for you if desired: https://pypi.org/project/appdirs/

Yes, I know, but I'm trying to avoid extra dependencies...

Does it works OK now?

[Frenzie]

Yes, it now runs fine out of the box, albeit still only in Python 2.7.

Python 3 looks like this:

Traceback (most recent call last):
  File "main.py", line 29, in <module>
    from gui_main import Ui_Base  # ___ ______ GUI STUFF ________________
  File "/home/frans/src/kobo/KoHighlights-master/gui_main.py", line 265, in <module>
    from main import DropTableWidget
  File "/home/frans/src/kobo/KoHighlights-master/main.py", line 30, in <module>
    from gui_about import Ui_About
  File "/home/frans/src/kobo/KoHighlights-master/gui_about.py", line 106, in <module>
    import images_rc
  File "/home/frans/src/kobo/KoHighlights-master/images_rc.py", line 21, in <module>
    qInitResources()
  File "/home/frans/src/kobo/KoHighlights-master/images_rc.py", line 16, in qInitResources
    QtCore.qRegisterResourceData(0x01, qt_resource_struct, qt_resource_name, qt_resource_data)
TypeError: 'qRegisterResourceData' called with wrong argument types:
  qRegisterResourceData(int, str, str, str)
Supported signatures:
  qRegisterResourceData(int, unicode, unicode, unicode)

On my desktop I got this error when scanning, perhaps because Python 2.7 is a bit weird about Unicode. However, I tracked it to a problematic file on my system called:

'Hy'$'\366''kk'$'\344''yksen Tiedot.doc'

It's not clear to me why it's problematic, because it sounds like it should just result in ẙ and, um, this one. It's actually supposed to read HYÖKKÄYKSEN. This is how wget saved it in a website mirroring command. Anyway, it doesn't seem like much you could do anything about. Python 3 *might* run into less of a problem. I haven't tried it.

Traceback (most recent call last):
  File "main.py", line 1925, in process
    self.start_scan()
  File "main.py", line 1929, in start_scan
    for dir_tuple in os.walk(self.path):
  File "/usr/lib/python2.7/os.py", line 296, in walk
    for x in walk(new_path, topdown, onerror, followlinks):
  File "/usr/lib/python2.7/os.py", line 296, in walk
    for x in walk(new_path, topdown, onerror, followlinks):
  File "/usr/lib/python2.7/os.py", line 296, in walk
    for x in walk(new_path, topdown, onerror, followlinks):
  File "/usr/lib/python2.7/os.py", line 296, in walk
    for x in walk(new_path, topdown, onerror, followlinks):
  File "/usr/lib/python2.7/os.py", line 296, in walk
    for x in walk(new_path, topdown, onerror, followlinks):
  File "/usr/lib/python2.7/os.py", line 296, in walk
    for x in walk(new_path, topdown, onerror, followlinks):
  File "/usr/lib/python2.7/os.py", line 286, in walk
    if isdir(join(top, name)):
  File "/usr/lib/python2.7/posixpath.py", line 73, in join
    path += '/' + b
UnicodeDecodeError: 'ascii' codec can't decode byte 0xf6 in position 3: ordinal not in range(128)

As an aside, this line is Windows-only:

elif dir_path.lower().endswith("koreader\\history")

[embryo]

Originally Posted by Frenzie

Python 3 looks like this:

Traceback (most recent call last):
  File "main.py", line 29, in <module>
    from gui_main import Ui_Base  # ___ ______ GUI STUFF ________________
  File "/home/frans/src/kobo/KoHighlights-master/gui_main.py", line 265, in <module>
    from main import DropTableWidget
  File "/home/frans/src/kobo/KoHighlights-master/main.py", line 30, in <module>
    from gui_about import Ui_About
  File "/home/frans/src/kobo/KoHighlights-master/gui_about.py", line 106, in <module>
    import images_rc
  File "/home/frans/src/kobo/KoHighlights-master/images_rc.py", line 21, in <module>
    qInitResources()
  File "/home/frans/src/kobo/KoHighlights-master/images_rc.py", line 16, in qInitResources
    QtCore.qRegisterResourceData(0x01, qt_resource_struct, qt_resource_name, qt_resource_data)
TypeError: 'qRegisterResourceData' called with wrong argument types:
  qRegisterResourceData(int, str, str, str)
Supported signatures:
  qRegisterResourceData(int, unicode, unicode, unicode)

Is it python 3 that asks for this? qRegisterResourceData(int, unicode, unicode, unicode)
That's strange.. (no unicode in python 3.x)

On my desktop I got this error when scanning, perhaps because Python 2.7 is a bit weird about Unicode. However, I tracked it to a problematic file on my system called:

'Hy'$'\366''kk'$'\344''yksen Tiedot.doc'

Can you pm me this file? (delete all the contents, I just want the filename and the .sdr if possible)

As an aside, this line is Windows-only:

elif dir_path.lower().endswith("koreader\\history")

Fixed it.

Thank you very much for your tests

[Frenzie]

Originally Posted by embryo

Is it python 3 that asks for this? qRegisterResourceData(int, unicode, unicode, unicode)
That's strange.. (no unicode in python 3.x)

Could be that I or Debian messed up something with the PySide dependencies for Python 3, or just a problem with PySide. I only meant I get that error if I run the program with Python 3.

I'll see if I can get the file with the corrupted name to you. It might be difficult seeing how it's corrupted and all, but I suppose tar should preserve it properly. Anyway, I don't have that file on my laptop.

[embryo]

Originally Posted by Frenzie

I'll see if I can get the file with the corrupted name to you.

Thank you..

[embryo]

• Updated to v0.6.1.0
  • Merging the highlights of a book that is read in two different devices is now possible (beta). It must be from the same reader engine though. Read about it here.
  • Syncing the reading position for a book that is read in two different devices is also possible now.
  • We can now edit highlight comments while in the "Highlights" view, using the right-click menu or double clicking.
  • From "Highlights" view, using the right-click menu, we can locate the current highlight to the "Books" view.
  • Changed: When scanning a directory using the "Scan Directory" button, the previously loaded books are not unloaded from the list.
  • Fixed: The same book's metadata are not loaded more than one time any more.
  • Fixed: The book's description text is now read only (as it should).

[embryo]

• Updated to v0.7.0.0
  • Option to sort highlights by Date or Page (in "Books" view).

[embryo]

Originally Posted by Frenzie

Could be that I or Debian messed up something with the PySide dependencies for Python 3, or just a problem with PySide.

Tried to run it with Python 3 and found out that Pyside could not get installed in Python after version 3.4.

I guess after that you need Pyside2..

[Frenzie]

How do you mean exactly? https://packages.debian.org/source/stretch/pyside

But PySide2/Qt5 would be preferable in the long run in any case.

[embryo]

Originally Posted by Frenzie

How do you mean exactly? https://packages.debian.org/source/stretch/pyside

I was trying to install Pyside in a Lubuntu 16.04 VM and I couldn't.
I read somewhere that it was because of "Pyside could not get installed in Python after version 3.4".

I setup another VM (Xubuntu) updated to 18.04 and succeed in installing everything.... and got to the same error as yours
It has to do with the pyside's resource creator (it creates code for Python2).

Bypassed it by not using it and loading the images from the original files.
Got an error from future.moves.urllib.request.URLError, bypassed it ... got another from ...

I'll get there some time in the future

But PySide2/Qt5 would be preferable in the long run in any case.

PySide2 needs Python3, and that is a problem for many other libraries or for backwards compatibility (I do have a system with XP on it, that can run all my apps)
I'm a Luddite I know, but I don't want to throw away machines that work fine, just so I can wait more time for loading the newer super duper Word or Photoshop

[embryo]

OK, the updated script should work with Python 2/3 out of the box.
There is a problem with the settings for the position of the window if python3 loads python2's settings file and vice versa, but everything else works.
Even a command-line interface is added.. (never made one before)