09-03-2024, 04:43 PM | #16 |
Guru
Posts: 771
Karma: 2297170
Join Date: Jan 2017
Location: Poland
Device: Various
|
Yes, I confirm.
Newest, fresh build from github. I did more tests. The problem only occurs if the entries in the OPF file (manifest + spine) exist, but the NCX file itself is missing. If the NCX file is not there and the OPF file is totally cleared then Sigil handles it. |
09-03-2024, 04:50 PM | #17 |
Sigil Developer
Posts: 8,109
Karma: 5450184
Join Date: Nov 2009
Device: many
|
But no actual crash, just an uncaught exception thrown. That is how it is supposed to work.
|
Advert | |
|
09-03-2024, 04:50 PM | #18 |
Bibliophagist
Posts: 39,751
Karma: 154147706
Join Date: Jul 2010
Location: Vancouver
Device: Kobo Sage, Libra Colour, Lenovo M8 FHD, Paperwhite 4, Tolino epos
|
Also if the toc.ncx is present in the epub but is not referenced in the content.opf, Sigil will offer to create a toc.ncx and then complain about an unmanifested file for the original toc.ncx.
|
09-03-2024, 04:53 PM | #19 |
Bibliophagist
Posts: 39,751
Karma: 154147706
Join Date: Jul 2010
Location: Vancouver
Device: Kobo Sage, Libra Colour, Lenovo M8 FHD, Paperwhite 4, Tolino epos
|
In the first case that BeckyeBook mentions where the toc.ncx is not present but is referenced in the content.opf, I get the show details/close popup but Sigil closes in a second or so.
|
09-03-2024, 04:56 PM | #20 |
Grand Sorcerer
Posts: 27,954
Karma: 198500000
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
My Sigil doesn't close. It claims it may need to close, but ultimately, it just opens to a default empty epub.
|
Advert | |
|
09-03-2024, 04:58 PM | #21 |
Sigil Developer
Posts: 8,109
Karma: 5450184
Join Date: Nov 2009
Device: many
|
I am seeing the following.
(because the epub is corrupt and claims a file in the manifest that does not exist). Sigil detects that and throws an exception resulting in the need for Sigil to close. Here is the message I am seeing: Sigil has encountered a problem. Sigil may need to close. Details: Error info: Cannot load file /Users/kbhend/Desktop/Dummy2.epub: /Users/kbhend/Library/Application Support/sigil-ebook/sigil/workspace/Sigil-ReZIKE/OEBPS/toc.ncx: No such file or directory Sigil version: 2.3.1 Runtime Qt: 6.7.2 Compiled Qt: 6.7.2 System: macOS Ventura (13.6) Architecture: x86_64 I do not get Sigil closing but that epub will not open resulting in a new empty window. |
09-03-2024, 05:00 PM | #22 | |
Sigil Developer
Posts: 8,109
Karma: 5450184
Join Date: Nov 2009
Device: many
|
Quote:
An actual crash will result in a segfault with abrupt shutdown, not being caught and later shutting down if needed. Last edited by KevinH; 09-03-2024 at 05:04 PM. |
|
09-03-2024, 05:03 PM | #23 | |
Bibliophagist
Posts: 39,751
Karma: 154147706
Join Date: Jul 2010
Location: Vancouver
Device: Kobo Sage, Libra Colour, Lenovo M8 FHD, Paperwhite 4, Tolino epos
|
Quote:
Event viewer shows: Spoiler:
|
|
09-03-2024, 05:04 PM | #24 |
Guru
Posts: 771
Karma: 2297170
Join Date: Jan 2017
Location: Poland
Device: Various
|
Hmmm… On my system (Windows 10 Pro) Sigil closes totally.
I am not able to click the “Show Details...” button because Sigil just shuts down. Tested on 2.3.0 original + 2.3.1 my build. |
09-03-2024, 05:05 PM | #25 |
Sigil Developer
Posts: 8,109
Karma: 5450184
Join Date: Nov 2009
Device: many
|
|
09-03-2024, 05:11 PM | #26 | |
Sigil Developer
Posts: 8,109
Karma: 5450184
Join Date: Nov 2009
Device: many
|
Quote:
It is not a bug as far as I am concerned as once the manifest can not be trusted, what can you do but error out letting the user know. My guess if you enable the Sigil DEBUG log file using an environment variable you might hopefully get more information. I am nicely seeing the reason in the details and no closing at all. Last edited by KevinH; 09-03-2024 at 05:19 PM. |
|
09-03-2024, 05:19 PM | #27 |
Guru
Posts: 771
Karma: 2297170
Join Date: Jan 2017
Location: Poland
Device: Various
|
The problem occurs for me when I run Sigil with the parameter. Then and only then I have a crash.
If Sigil is opened and I manually select the problematic epub file from disk - I can click the “Show Details...” button. In that case no crash. Code:
Error info: Cannot load file d:\Download\Dummy2.epub: C:/Users/Becky/AppData/Local/sigil-ebook/sigil/workspace/Sigil-gBnKeE/OEBPS/toc.ncx: Nie można odnaleźć określonego pliku. Sigil version: 2.3.1 Runtime Qt: 6.7.2 Compiled Qt: 6.7.2 System: Windows 10 Version 22H2 Architecture: x86_64 |
09-03-2024, 05:19 PM | #28 |
Grand Sorcerer
Posts: 27,954
Karma: 198500000
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
But I think they are saying the Sigil IS abruptly closing on them. Even 2.3.1.
|
09-03-2024, 05:22 PM | #29 |
Grand Sorcerer
Posts: 27,954
Karma: 198500000
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
Ahh... maybe another case of a problem stemming from double-clicking an epub rather using File->Open from a running Sigil?
|
09-03-2024, 05:31 PM | #30 |
Sigil Developer
Posts: 8,109
Karma: 5450184
Join Date: Nov 2009
Device: many
|
Either way you end up in the LoadFile() routine in MainWindow.cpp and the exception (a runtime exception) is caught here:
Code:
} catch (const std::runtime_error &e) { ShowMessageOnStatusBar(); // ImportHTML/ImportEPUB use wait cursor and can throw exceptions caught here QApplication::restoreOverrideCursor(); Utility::DisplayExceptionErrorDialog(tr("Cannot load file %1: %2") .arg(QDir::toNativeSeparators(fullfilepath)) .arg(e.what())); } catch (QString& err) { ShowMessageOnStatusBar(); // ImportHTML/ImportEPUB use wait cursor and can throw exceptions caught here QApplication::restoreOverrideCursor(); Utility::DisplayStdErrorDialog(err); } // If we got to here some sort of error occurred while loading the file // and potentially has left the GUI in a nasty state (like on initial startup) // Fallback to displaying a new book instead so GUI integrity is maintained. CreateNewBook(); return false; } And a new empty epub is created as a result in an attempt to keep going. So for some reason, this code is not happening when launching sigil by double-clicking on a epub on Windows? |
|
Similar Threads | ||||
Thread | Thread Starter | Forum | Replies | Last Post |
Updated CC (3.5.6) crashes upon opening | SuzDavid | Calibre Companion | 16 | 11-22-2014 10:18 AM |
Opening EPUBs in Sigil takes ages [Windows] | Wasserpulle | Sigil | 4 | 12-13-2013 01:05 PM |
SIGIL Crashes When Opening Files on MacBook Pro | WilliamGarner | Sigil | 2 | 10-09-2013 09:07 AM |
Epub crashes on Sigil for Mac, OK on Sigil for PC | crystamichelle | Sigil | 6 | 08-14-2013 02:52 PM |
4.129 crashes upon opening | da_jane | Calibre | 7 | 01-19-2009 02:25 AM |