[Editor Plugin] EpubCheck

[jackie_w]

... additional info in case it's relevant ...

The /sysfiles/temp part of my versions of the 'message' fields are my Windows Temp directory which is actually located at D:\sysfiles\Temp not the default C:\Users\username\AppData\Local\Temp

Might this be the problem?

[jackie_w]

Following up on my own thoughts...

I've managed to make EpubCheck work on my PC by making the following minor changes:

1. lines 154-157

                    if iswindows:
                        # drive_letter = os.getenv("SystemDrive")    
                        # line = re.sub(drive_letter, 'C^',  line)
                        # line = re.sub(drive_letter.lower(), 'C^',  line)
                        pathx = epub_path.replace(os.sep, '/')
                        line = re.sub(pathx, '',  line)

and also comment out lines 191 and 192

                    # if iswindows:
                    #    filename = os.path.basename(re.sub('C^', drive_letter, filename))

Only time will tell whether it's a robust solution or a temporary Band-Aid

[BetterRed]

Originally Posted by jackie_w

... additional info in case it's relevant ...

The /sysfiles/temp part of my versions of the 'message' fields are my Windows Temp directory which is actually located at D:\sysfiles\Temp not the default C:\Users\username\AppData\Local\Temp

So... it seems you are not a '...a plain old Windows user..."

Originally Posted by jackie_w

Might this be the problem?

Could be - in theory plugins 'should' use the same place for their temporary files as the host application uses, but with a wrapper around 3rd party java code who knows.

Calibre's temporary location can be set by the CALIBRE_TEMP_DIR environment variable.

There are two sets of TEMP and TMP environment variables, one at the System and one per User level. I don't why, when, and by what the System ones are used, I've never noticed them at my %systemroot% location. There's also a Temp folder in %windir%

It might also be the Path setting, make sure there's only one entry for Java in particular.

I find Rapid Environment Editor useful for 'managing' environment variables, see attachment.

BR

[jackie_w]

Originally Posted by BetterRed

So... it seems you are not a '...a plain old Windows user..."

Emphasis on the 'old'

When I got this new laptop I was told my C: drive was an SSD drive and that they wore out faster than normal hard disks. Given how much calibre epub tweaking I do I concluded the Temp directory was going to see a lot of action so I'd better move it to the D: drive which is not SSD. All my programs are installed on C:. (I wish I fully understood what I've just written).

[BetterRed]

Originally Posted by jackie_w

Emphasis on the 'old'

As long as it's not on the 'plain'

SSD's wearing out faster is theoretically true, but for practical purposes its an Urban Myth

But why not give calibre its own temp folder - as I have, not to save war and tar on my SSD just so's I can get at things when I want them.

BR

[Feldegast]

when i run epub check it shows me the 1st html file that has an error but not files after that and if the 1st error is not in the 1st html file it doesn't show the name of the 1st file with an error
when i run the same file on http://validator.idpf.org/application/validate it shows the file names

instead of the file name it returns NA

i am using epub check 0.1.1
calibre 3.0
on OSX Sierra 10.12.5

[Doitsu]

Originally Posted by Feldegast

when i run epub check it shows me the 1st html file that has an error but not files after that

The plugin hasn't been thoroughly tested with the macOS version of Calibre. BTW, it's known to cause problems, if users change the default temp folder location.

In order to fix this problem, I'll need the file that caused this problem. Please zip it up in a password protected .zip file and send me the download link and the password via PM.

[Feldegast]

i will send you the next one i find an issue with
i have not changed the location of the temp folder

[thiago.eec]

Hi, @Doitsu

Thanks for the great plugin.

Just one question: is it possible to prevent the CMD window showing up when the plugin is running? The Sigil version does not show the CMD window. It looks more clean that way.

[Doitsu]

Originally Posted by thiago.eec

Just one question: is it possible to prevent the CMD window showing up when the plugin is running? The Sigil version does not show the CMD window. It looks more clean that way.

I don't see a CMD window on my Windows machine.
Can you please take a screen capture of it?

What's your operating system?

[thiago.eec]

Originally Posted by Doitsu

I don't see a CMD window on my Windows machine.
Can you please take a screen capture of it?

What's your operating system?

I'm using Windows 10 x64 (1809 version). My Calibre is version 3.33.1 (latest).
The CMD window open shows for two seconds, then closes itself.

[Doitsu]

Originally Posted by thiago.eec

I'm using Windows 10 x64 (1809 version). My Calibre is version 3.33.1 (latest).
The CMD window open shows for two seconds, then closes itself.

Since I wasn't able to reproduce this issue on my 64bit Windows 10 machine with the latest Calibre version, this is most likely an OS/Java issue, which I can't fix.

[thiago.eec]

Originally Posted by Doitsu

Since I wasn't able to reproduce this issue on my 64bit Windows 10 machine with the latest Calibre version, this is most likely an OS/Java issue, which I can't fix.

I've tested it on another machine with Windows 10 Pro x64 (1803 version) and I noticed something:

1) If I open Calibre main program, select the book and click EDIT BOOK, then the CMD Window won't show up.
2) If I open the book directly with the Editor (by right-clicking on the file and choosing the Editor), then the CMD shows up. This happens even if Calibre main program is still running.

This is happening on both my machines.

Looks like the Editor doesn't work independently of the main program. Maybe, when I click on EDIT BOOK, calibre treats it differently from when I open the Editor as a standalone process.

[kovidgoyal]

the editor does work independently of the main program. @Doitsu when you call subprocess to run epubcheck, you should specify the creationflags variable to ensure cd window is not created. something like

import win32process
subprocess.Popen(...., creationflags=win32process.CREATE_NO_WINDOW)

[Doitsu]

Originally Posted by kovidgoyal

the editor does work independently of the main program. @Doitsu when you call subprocess to run epubcheck, you should specify the creationflags variable to ensure cd window is not created. something like

import win32process
subprocess.Popen(...., creationflags=win32process.CREATE_NO_WINDOW)

Thanks for the code snippet! I'll add it to the plugin and release a new version today.