Future Release To-Do Items

[BeckyEbook]

Originally Posted by KevinH

@BeckyEbook - I think that takes care of your bug list related to tab to shift focus so far.
Please let me know if you run into any new places that break tab to shift focus.

This is probably the last place: Index Editor.

[KevinH]

Originally Posted by retiredbiker

Just fyi, tried to build from Master just now, and getting the following make error (POP_OS, like Ubuntu 22.04):

Yes, I used a too new routine. Just checked and there is a isValidColor that works in earlier versions. I will ifdef that in.

Thanks!

[KevinH]

Originally Posted by BeckyEbook

This is probably the last place: Index Editor.

Is it another widget the captures focus or is the order wrong?

I tried it and I was able to tab between the Filter, the Table of Index Entries, the AddEntry button and Save button in a cycle.

Does that work for you?

[KevinH]

Originally Posted by retiredbiker

Just fyi, tried to build from Master just now, and getting the following make error (POP_OS, like Ubuntu 22.04):

I just pushed a fix for this to master.

Thanks!

[BeckyEbook]

Ad Index Editor.
You are right. Once all the index items have passed, the focus jumps off the table, so all is well here.

[KevinH]

Originally Posted by BeckyEbook

Ad Index Editor.
You are right. Once all the index items have passed, the focus jumps off the table, so all is well here.

Great! Thanks for all your help tracking down these bugs.

I think Tab to shift focus is in pretty good shape now.

[KevinH]

Okay, I did notice one thing on macOS.

The highlight we add for CodeView can never seem to get larger that 1px even if we change the qss border style but the natural highlights generated by macOS seem to be about 3 pixels or more wide.

So can everyone see the 1px solid highlight properly on their platforms? Does it match the highlight width used on QComboBoxes (see FindReplace) generated by your system style?

Would it be better to change the Sigil generated highlight from 1px to 3px and make the associated padding-top, padding-bottom, ... changes to give Sigil enough room to draw the border properly?

@Doitsu, @BeckyEbook, @DiapDealer, @retiredbiker, @BetterRed?

Thoughts?

[BeckyEbook]

I have the impression that on most widgets the default focus is 1px. But, for example, when you open the Preferences window, the OK button might have a 1px or with focus a 2px border.

EDIT: Presumably hover and focus+hover has a 1px border. The focus on the button itself may have a 2px.

[BeckyEbook]

@DiapDealer: By the way, I think I see a problem with the recent commits regarding the inclusion of stylling when the wider cursor option is enabled.

Can't switch to a light theme by using an environment variable.

[KevinH]

Originally Posted by BeckyEbook

I have the impression that on most widgets the default focus is 1px. But, for example, when you open the Preferences window, the OK button might have a 1px or with focus a 2px border.

EDIT: Presumably hover and focus+hover has a 1px border. The focus on the button itself may have a 2px.

Thanks.

So I will leave Windows focus border as is.

On macOS, I will use a 3px border.

if not mac and not windows (Linux) yet to be determined.

[retiredbiker]

Originally Posted by KevinH

Okay, I did notice one thing on macOS.

The highlight we add for CodeView can never seem to get larger that 1px even if we change the qss border style but the natural highlights generated by macOS seem to be about 3 pixels or more wide.

So can everyone see the 1px solid highlight properly on their platforms? Does it match the highlight width used on QComboBoxes (see FindReplace) generated by your system style?

Would it be better to change the Sigil generated highlight from 1px to 3px and make the associated padding-top, padding-bottom, ... changes to give Sigil enough room to draw the border properly?

@Doitsu, @BeckyEbook, @DiapDealer, @retiredbiker, @BetterRed?

Thoughts?

So I've tried looking at various widgets with the highlight focus turned on and off, and frankly I can hardly see any difference on my pop_os machine.

The double width cursor in the code view does work perfectly, very nice!

Here are various shots of things with focus highlight turned on and off. The most visible highlighting, to my old eyes, is the file tabs at the top of the code view window. The file names on hover will tell you if the focus highlight is on or off.

Let me know if there is some specific spot you'd like me to look at...

[KevinH]

Originally Posted by retiredbiker

So I've tried looking at various widgets with the highlight focus turned on and off, and frankly I can hardly see any difference on my pop_os machine.

The double width cursor in the code view does work perfectly, very nice!

Here are various shots of things with focus highlight turned on and off. The most visible highlighting, to my old eyes, is the file tabs at the top of the code view window. The file names on hover will tell you if the focus highlight is on or off.

Let me know if there is some specific spot you'd like me to look at...

Great! What about the focus highlight size for Preview, CodeView, BookBrowser, etc. Do they look like a good width or should they be wider?

[retiredbiker]

Everything looks good in Preview and CodeView. In BookBrowser there doesn't seem anything to focus on? Tab and hover have no effect, tried it both docked and undocked. When it is docked, tabbing just goes into CodeView, and if floating tabbing does nothing at all that I can see.

To try and see what is supposed to be different, I tried changing the color with

$ export SIGIL_FOCUS_HIGHLIGHT_COLOR="#FF4D00"

If I understand right that should turn the highlight orange, but I can't get it to work. Er...that is an environment variable?

[KevinH]

Using my Manjaro Linux KDE desktop as a test case, it seems on Linux all of the buttons, controls, lineedits, and comboboxes are all properly highlighted natively (so no need to add our highlighting to them). Only the major widgets/ qdockwidgets contents need to have focus highlights added to them.

I have now pushed this to master.

[KevinH]

Originally Posted by retiredbiker

Everything looks good in Preview and CodeView. In BookBrowser there doesn't seem anything to focus on? Tab and hover have no effect, tried it both docked and undocked. When it is docked, tabbing just goes into CodeView, and if floating tabbing does nothing at all that I can see.

To try and see what is supposed to be different, I tried changing the color with

$ export SIGIL_FOCUS_HIGHLIGHT_COLOR="#FF4D00"

If I understand right that should turn the highlight orange, but I can't get it to work. Er...that is an environment variable?

That should have worked. My guess is you have either not turned on the Sigil focus highlighting in Sigil Preferences Appearances MainUI or not restarted after it.

The reason it is hard to tell is that on Linux most of the focus highlighting is done natively by your desktop. Sigil will not try to overwrite it with your own. You control that in your Desktop Settings. All Sigil can control is the color of the highlights it adds. These include around the border of each of the major QDockWidgets. Those are the only highlight colors that Sigil can control.

So on Linux to completely change all focus highlighting, you would need to change both the Sigil highlight color with an environment variable and then make sure you have used your own Desktop settings to set the proper color for its built-in highlighting.

By default, Sigil will look at your native highlight color and choose the match it unless you use the environment variable. So on Linux, the changing the system desktop highlighting color should be enough to change all (no need for the environment variable). On platforms like MacOS that has very little native highlighting, the environment variable is a useful way of fine tuning the color.