12-18-2020, 04:45 PM | #136 |
Custom User Title
Posts: 9,096
Karma: 62580135
Join Date: Oct 2018
Location: Canada
Device: Kobo Libra H2O, formerly Aura HD
|
I suspect the problem might be with Mark Books itself. The Favourites menu plugin has the same problem if you add Show Marked Books to it. I can submit a bug request if you'd like.
|
12-18-2020, 05:28 PM | #137 |
Wizard
Posts: 1,130
Karma: 1954142
Join Date: Aug 2015
Device: Kindle
|
So apparently, when I handled the error the previous time, I normalized the menu entry from "Show marked books (7)" to be "Show marked books" and throw away the number in the parenthesis.
Turned out that when there is only one book marked, calibre changes the menu entry into "Show marked book" which would not match my test: Code:
if safe_name.startswith("Show marked books")
You described the problem as a regression from the previous version, while this problem has been there all along. If you can confirm that it only happens when only one book is marked I will release a fix, otherwise, will have to dig deeper to find the cause. Edit: That is why I was not able to re-produce the behavior, was testing with multiple books marked. Last edited by capink; 12-18-2020 at 05:30 PM. |
Advert | |
|
12-18-2020, 05:32 PM | #138 |
Custom User Title
Posts: 9,096
Karma: 62580135
Join Date: Oct 2018
Location: Canada
Device: Kobo Libra H2O, formerly Aura HD
|
Another oddity: When you first start Calibre, it appears as "Show marked books". It doesn't add the (0) until books are marked and then cleared.
In my case, it happened when there were no books marked at all. But maybe removing the plural would help anyways. |
12-18-2020, 05:39 PM | #139 |
Wizard
Posts: 1,130
Karma: 1954142
Join Date: Aug 2015
Device: Kindle
|
OK, I posted a test version in the second post of this thread. Please try and report back.
|
12-18-2020, 05:41 PM | #140 |
Custom User Title
Posts: 9,096
Karma: 62580135
Join Date: Oct 2018
Location: Canada
Device: Kobo Libra H2O, formerly Aura HD
|
I filed a bug report, in case it can also be fixed on the Calibre end: https://bugs.launchpad.net/calibre/+bug/1908762
|
Advert | |
|
12-18-2020, 05:44 PM | #141 |
Wizard
Posts: 1,130
Karma: 1954142
Join Date: Aug 2015
Device: Kindle
|
I don't think it is a bug in Calibre. It is an intended behavior.
|
12-18-2020, 05:47 PM | #142 |
Custom User Title
Posts: 9,096
Karma: 62580135
Join Date: Oct 2018
Location: Canada
Device: Kobo Libra H2O, formerly Aura HD
|
Yes, it's intended - but it causes some clumsy behaviour so my hopes is perhaps whatever the Reading List plugin does to avoid the issues could also be applied.
|
12-18-2020, 05:51 PM | #143 |
Wizard
Posts: 1,130
Karma: 1954142
Join Date: Aug 2015
Device: Kindle
|
kiwidude designed all his plugins to play nice with his favourites menu plugin (which the code for calibre actions is based on), by inserting a constant attribute called 'favourites_menu_unique_name' if the menu entry changes name.
|
12-18-2020, 05:53 PM | #144 |
Custom User Title
Posts: 9,096
Karma: 62580135
Join Date: Oct 2018
Location: Canada
Device: Kobo Libra H2O, formerly Aura HD
|
That makes sense.
|
12-18-2020, 05:54 PM | #145 |
Custom User Title
Posts: 9,096
Karma: 62580135
Join Date: Oct 2018
Location: Canada
Device: Kobo Libra H2O, formerly Aura HD
|
Sorry it's taking so long - I grabbed a random fic to test and it's taking forever to download.
|
12-18-2020, 05:59 PM | #146 |
Custom User Title
Posts: 9,096
Karma: 62580135
Join Date: Oct 2018
Location: Canada
Device: Kobo Libra H2O, formerly Aura HD
|
It seems to be behaving again, using the same replication steps as I posted earlier. Thank you.
|
12-18-2020, 06:04 PM | #147 |
Wizard
Posts: 1,130
Karma: 1954142
Join Date: Aug 2015
Device: Kindle
|
Good to know, will move it to the first post.
|
12-18-2020, 08:57 PM | #148 |
Interested in the matter
Posts: 421
Karma: 426094
Join Date: Dec 2011
Location: Spain, south coast
Device: Pocketbook InkPad 3
|
Version 0.3.3
Show Marked Books. Now it works perfectly. Thanks a lot. |
12-19-2020, 06:02 AM | #149 | |
Grand Sorcerer
Posts: 11,867
Karma: 7036359
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
|
Quote:
You should replace the copies you got from my posts with the versions on github. |
|
12-19-2020, 07:33 AM | #150 |
Wizard
Posts: 1,130
Karma: 1954142
Join Date: Aug 2015
Device: Kindle
|
Done.
|
|
Similar Threads | ||||
Thread | Thread Starter | Forum | Replies | Last Post |
[Editor Plugin] Editor Chains | capink | Plugins | 94 | 07-03-2024 07:26 PM |
Action Chains Resources | capink | Plugins | 65 | 07-01-2024 03:12 PM |
[GUI Plugin] Noosfere_util, a companion plugin to noosfere DB | lrpirlet | Plugins | 2 | 08-18-2022 03:15 PM |
[GUI Plugin] Save Virtual Libraries To Column (GUI) | chaley | Plugins | 14 | 04-04-2021 05:25 AM |