Request: Change to Validation Results window title

[mrprobert]

Is it possible to change the Validation Results window title to reflect the type of validation performed? I use the CSSValidator and EpubCheck plugins, and "Well-Formed Check EPUB".

[KevinH]

Why does that matter? The Validation Results Window holds that last validation run you made no matter what validation tool you use. If in doubt, rerun it.

Given tool names will need to be translated and added to the titlebar, that is just not something I am willing to do.

[mrprobert]

Yup, it's no biggie. Thanks for your explanation.

[BeckyEbook]

My two cents:
I even like this idea. I guess there is no need for additional translation if you use the standard window title and just add the plugin name.

setWindowTitle(tr("Validation Results") + " • " + PluginNameHere);

It works for me.

[KevinH]

Originally Posted by BeckyEbook

My two cents:
I even like this idea. I guess there is no need for additional translation if you use the standard window title and just add the plugin name.

setWindowTitle(tr("Validation Results") + " • " + PluginNameHere);

It works for me.

Where exactly are you setting setWindowTitle at?
Where are you getting m_pluginName from?
Will your approach work with the embedded python SanityCheck since it is not a plugin?

Please post a diff or PR with your changes to implement this if you have them?

Thanks!

[BeckyEbook]

Hmmm... It works for Well-Formed Check EPUB (F7) and for validation plugins.
For SanityCheck itself I haven't checked, since it's probably called every time we use Validation Results.

I'll test it during normal operation for a few days and if I don't find some unpleasant side effect I'll send the diffs so you can figure out the proper naming for the voids yourself.

In brief:
For plugins: PluginRunner [plugin name] -> MainWindow -> ValidationResultsView
For Well-Formed: MainWindow::WellFormedCheckEpub() -> ValidationResultsView

void ValidationResultsView::setNewValidationTitle(const QString &text) {
    setWindowTitle(tr("Validation Results") + " • " + text);
}