Removing calibre classes...

[Doitsu]

Originally Posted by carmenchu

I have implemented a variant of your suggestion, and (I hope!) avoided the trouble of a void "tags": "", getting the "tags" preferences obliterated on next run.

Unfortunately,

ttags = [True,prefs['tags'].split(',')][len(prefs['tags']) > 0 or 0] # evaluates to 1|0 for tags|no tags

doesn't work for empty strings. Since it was my idea anyway, simply remove the part that checks for empty strings.

Originally Posted by carmenchu

It's an option which I wouldn't recommend, save for report purposes: one can achieve the same result by a simple search & replace of class="calibre\d*"

Indeed. Maybe it isn't a good idea to have such an option.

Originally Posted by carmenchu

By the way, is there a simple way of getting the list of tags ordered? It would be easier to read and edit, but I can't get it done...

The built-in sort() function should also work for lists.

BTW, one other free Python book I can highly recommend is Automate the Boring Stuff with Python by Al Sweigart, which is available online and as a paid e-book.

[carmenchu]

Well, attached is a new version, with:
- Option 'no tags' removed--it couldn't even be reported, lacking a list of tags for reference.
- Added a message (Qt) with buttons to choose on the fly if run only for reports (default -> OK) or to apply the changes (Cancel).
That would be useful before choosing to add/remove tags from preferences.
- Changed the versioning: this is v1_0, (implicitly making previous ones 0_x)
- Automatically sort the tag list (easier to inspect/edit), besides trying to ensure that it works.
Unfortunately, as it MUST be a comma-separated list, without spaces, the code is quite clumsy. A less unwieldy alternative would be appreciated.

Spoiler:

# protect editable string from mistype
def sanitize(string):
    if string != (' '):
        string = string.replace(' ','')
        string = string.replace(',,',',')
        string = string.lower()
        lstring = string.split(',')
        ostring = sorted(lstring)[0]
        for s in sorted(lstring)[1:]: # list of comma-separated strings
            ostring = ostring + "," + s
        # MUST be list of words(=tag names) comma-separated & without spaces
        string = ostring.replace(' ','')
    else:
        string = ' ' # Avoid bk.savePrefs(prefs) deleting the "tags" entry?--general havoc
    return string

* Query: are buttons of the message easy to understand, o rather counter-intuitive?

[Doitsu]

Originally Posted by carmenchu

Unfortunately, as it MUST be a comma-separated list, without spaces, the code is quite clumsy. A less unwieldy alternative would be appreciated.

Actually, you can save Python lists in the preference file.

Originally Posted by carmenchu

Query: are buttons of the message easy to understand, o rather counter-intuitive?

I'd simply use Yes and No to avoid confusion.

    msg.setStandardButtons(QMessageBox.Yes | QMessageBox.No)
    testmode = [0,1][msg.exec_()== QMessageBox.Yes]

[carmenchu]

I'd simply use Yes and No to avoid confusion.

    msg.setStandardButtons(QMessageBox.Yes | QMessageBox.No)
    testmode = [0,1][msg.exec_()== QMessageBox.Yes]

A ton of thanks: works fine.
And, BTW, is there an equally simple way to substite the default icon of the message box (quite horrid, at least in my win10) with the plug-in icon, for instance?
If yes, I would wait to update the upload...
*Query*: uploading a new file with the name, would result in updating the previous attachment, or must one attach again? My ignorance

Originally Posted by Doitsu

Actually, you can save Python lists in the preference file.

Good to know: but think of the irritation of having to manually add 3 more tags to 'a','br','b',...

[Doitsu]

Originally Posted by carmenchu

And, BTW, is there an equally simple way to substite the default icon of the message box (quite horrid, at least in my win10) with the plug-in icon, for instance?

Unfortunately, I can't help you with that. Maybe @DiapDealer or @KevinH know how to do this.

Originally Posted by carmenchu

*Query*: uploading a new file with the name, would result in updating the previous attachment, or must one attach again? My ignorance

No idea. I usually attach files with different file names.

[carmenchu]

Thanks! Attaching the corrected version.

[AlanHK]

Originally Posted by carmenchu

# get all i,b,small,sup,sub,br,a,li tags with class='*calibre*' (containing all those characters, in fact)

So this strips <i class="calibreX"> to <i>?

Occasionally, I see cases where the style makes it bold italic, not just italic.

Generally that seems to be set on words in a longer bold passage:

<p><b>Words in bold</b><i class=CalibreX">words bold italic</i><b> More bold</b></p>

So it's a good idea to inspect the definitions before running such a conversion.

[JSWolf]

Originally Posted by AlanHK

So this strips <i class="calibreX"> to <i>?

Occasionally, I see cases where the style makes it bold italic, not just italic.

Generally that seems to be set on words in a longer bold passage:

<p><b>Words in bold</b><i class=CalibreX">words bold italic</i><b> More bold</b></p>

So it's a good idea to inspect the definitions before running such a conversion.

I have never seen an <i class="calibreX"> where you cannot remove the class and leave just <i>.

[DNSB]

Originally Posted by JSWolf

I have never seen an <i class="calibreX"> where you cannot remove the class and leave just <i>.

I've seen a couple of times where calibre has left bold and italic inside either a <b> or <i> tag. Relatively rare and a quick search will find them.

[AlanHK]

Originally Posted by carmenchu

Thanks! Attaching the corrected version.

Can I suggest you update the first post in the thread so it always has the latest version.

Wishlist for other "fixes":

Calibre seems to always name the cover "titlepage.xhtml", which is really grating to me, since it's not the title page. I always rename it to cover.xhtml (except if there is already a cover.xhtml). Can that be an option?

Seems that Calibre always adds "display: block;" to style definitions. Can that be removed optionally?

The <body> tag is invariably <body class="calibre">
Can that be made just <body> and the style .calibre renamed "body"?

Originally Posted by JSWolf

I have never seen an <i class="calibreX"> where you cannot remove the class and leave just <i>.

Yeah, I just made it up. You got me.

Has anyone ever asked Kovid why Calibre does these redundant styles? Does Calibre still do it?

It's not hard to fix by S&R, but it does get tedious. But I can't see the structure of the file until I clean away all the cruft.

[sadhu44]

Tried to add the redundant1 plug-n, but got this error: InvalidPlugin:The plugin in ... redundanti8_v1.zip is invalid. It does not contain a top-level _init_.py file.

[KevinH]

Originally Posted by sadhu44

Tried to add the redundant1 plug-n, but got this error: InvalidPlugin:The plugin in ... redundanti8_v1.zip is invalid. It does not contain a top-level _init_.py file.

This plugin is for Sigil not calibre.

[DiapDealer]

Originally Posted by sadhu44

It does not contain a top-level _init_.py file.

And it shouldn't. Sigil plugins don't contain a top-level __init__.py file. Note that you also should not unzip, or alter the plugin archive in any way--including renaming the archive. Some browser download "helpers" rename files automatically.

EDIT: Ahh... as Kevin noted, it does indeed seem as if you are trying to install a Sigil plugin into calibre. That definitely will not work.

[sadhu44]

wups. Sorry, fellas.

[arcchancellor]

Is it possible to add an option in RedundantI to add more Calibre tags like body, headers, metadata and dc:identifier?