Experimental FBReader v0.12.10 port

[Mackx]

Originally Posted by fekhner

I made a short test on a large chm file that I had problems with before and it seems to work very well on DR1000, it indeed creates its own tab ...

Hi Glenn,

How do you scroll down on a large help section? Are you using the stylus or a key combination that I do not know yet? In 0.10.7 a short-press would scroll one page down and a long-press would get you to the next section. Is there a new trick in 0.12.10?

Marcel.

[Iñigo]

Hi Marcel,

Originally Posted by Mackx

Hi Glenn,

How do you scroll down on a large help section? Are you using the stylus or a key combination that I do not know yet? In 0.10.7 a short-press would scroll one page down and a long-press would get you to the next section. Is there a new trick in 0.12.10?

Marcel.

These are all the posible actions (from "fbreader/src/fbreader/FBReaderActionCode.cpp"):

Spoiler:

const std::string ActionCode::SHOW_READING = "showReading";
const std::string ActionCode::SHOW_LIBRARY = "showLibrary";
const std::string ActionCode::SHOW_NETWORK_LIBRARY = "showNetLibrary";
const std::string ActionCode::SHOW_TOC = "toc";
const std::string ActionCode::SHOW_HELP = "showHelp";
const std::string ActionCode::SHOW_BOOK_INFO_DIALOG = "bookInfo";
const std::string ActionCode::SHOW_OPTIONS_DIALOG = "preferences";
const std::string ActionCode::UNDO = "undo";
const std::string ActionCode::REDO = "redo";
const std::string ActionCode::SEARCH = "search";
const std::string ActionCode::FIND_PREVIOUS = "findPrevious";
const std::string ActionCode::FIND_NEXT = "findNext";
const std::string ActionCode::PAGE_SCROLL_FORWARD = "pageForward";
const std::string ActionCode::PAGE_SCROLL_BACKWARD = "pageBackward";
const std::string ActionCode::LINE_SCROLL_FORWARD = "lineForward";
const std::string ActionCode::LINE_SCROLL_BACKWARD = "lineBackward";
const std::string ActionCode::MOUSE_SCROLL_FORWARD = "mouseScrollForward";
const std::string ActionCode::MOUSE_SCROLL_BACKWARD = "mouseScrollBackward";
const std::string ActionCode::TAP_SCROLL_FORWARD = "tapScrollForward";
const std::string ActionCode::TAP_SCROLL_BACKWARD = "tapScrollBackward";
const std::string ActionCode::SCROLL_TO_HOME = "gotoHome";
const std::string ActionCode::SCROLL_TO_START_OF_TEXT = "gotoSectionStart";
const std::string ActionCode::SCROLL_TO_END_OF_TEXT = "gotoSectionEnd";
const std::string ActionCode::CANCEL = "cancel";
const std::string ActionCode::INCREASE_FONT = "increaseFont";
const std::string ActionCode::DECREASE_FONT = "decreaseFont";
const std::string ActionCode::SHOW_HIDE_POSITION_INDICATOR = "toggleIndicator";
const std::string ActionCode::TOGGLE_FULLSCREEN = "toggleFullscreen";
const std::string ActionCode::FULLSCREEN_ON = "onFullscreen";
const std::string ActionCode::ADD_BOOK = "addBook";
const std::string ActionCode::ROTATE_SCREEN = "rotate";
const std::string ActionCode::QUIT = "quit";
const std::string ActionCode::FORCE_QUIT = "forceQuit";
const std::string ActionCode::OPEN_PREVIOUS_BOOK = "previousBook";
const std::string ActionCode::GOTO_NEXT_TOC_SECTION = "nextTOCSection";
const std::string ActionCode::GOTO_PREVIOUS_TOC_SECTION = "previousTOCSection";
const std::string ActionCode::COPY_SELECTED_TEXT_TO_CLIPBOARD = "copyToClipboard";
const std::string ActionCode::CLEAR_SELECTION = "clearSelection";
const std::string ActionCode::OPEN_SELECTED_TEXT_IN_DICTIONARY = "openInDictionary";
const std::string ActionCode::GOTO_PAGE_NUMBER = "gotoPageNumber";
const std::string ActionCode::GOTO_PAGE_NUMBER_WITH_PARAMETER = "gotoPageNumberWithParameter";
const std::string ActionCode::SEARCH_ON_NETWORK = "searchOnNetwork";
const std::string ActionCode::ADVANCED_SEARCH_ON_NETWORK = "advancedSearchOnNetwork";
const std::string ActionCode::ORGANIZE_BOOKS_BY_AUTHOR = "byAuthor";
const std::string ActionCode::ORGANIZE_BOOKS_BY_TAG = "byTag";
const std::string ActionCode::FILTER_LIBRARY = "filterLibrary";

Can't you use any of these:

PAGE_SCROLL_FORWARD = "pageForward";
PAGE_SCROLL_BACKWARD = "pageBackward";
LINE_SCROLL_FORWARD = "lineForward";
LINE_SCROLL_BACKWARD = "lineBackward";
MOUSE_SCROLL_FORWARD = "mouseScrollForward";
MOUSE_SCROLL_BACKWARD = "mouseScrollBackward";
TAP_SCROLL_FORWARD = "tapScrollForward";
TAP_SCROLL_BACKWARD = "tapScrollBackward";
SCROLL_TO_HOME = "gotoHome";
SCROLL_TO_START_OF_TEXT = "gotoSectionStart";
SCROLL_TO_END_OF_TEXT = "gotoSectionEnd";

Look at the ones you are using in 0.10.x, check the new name for those actions and rebind them in preferences->keys.
I think pageForward and pageBackward are the actions you are looking for.

To bind a key, go to tab "keys" in preferences, click on the entry to the right of label "Action for key", press the key, and select the wanted action on the dropbox that will appear below.
Then repeat for all the keys you want to bind.

They are stored in <config_path>/.FBReader/options.xml.
Here is my file:

Spoiler:

<?xml version="1.0" encoding="UTF-8"?>
<config>
<group name="Encoding">
<option name="UseWindows1252Hack" value="false"/>
</group>
<group name="Keys">
<option name="Action0" value="pageForward"/>
<option name="Action1" value="nextTOCSection"/>
<option name="Action2" value="previousTOCSection"/>
<option name="Action3" value="pageBackward"/>
<option name="Key0" value="&lt;DownArrow&gt;"/>
<option name="Key1" value="&lt;PageDown&gt;"/>
<option name="Key2" value="&lt;PageUp&gt;"/>
<option name="Key3" value="&lt;UpArrow&gt;"/>
<option name="Number" value="4"/>
</group>
<group name="Options">
<option name="ScanSubdirs" value="true"/>
</group>
<group name="Web Browser">
<option name="Enabled" value="false"/>
<option name="Name" value="Browser"/>
</group>
</config>

Hope it helps,
Iñigo

[Mackx]

Hi Iñigo,

I was looking at Programs\_fbreader\share\FBReader\default\keymap.x ml, that was the wrong file. Thanks for pointing at options.xml.

So for all others: Check your options.xml file for the following entries:
<option name="Action0" value="pageForward"/>
<option name="Action1" value="nextTOCSection"/>
<option name="Action2" value="previousTOCSection"/>
<option name="Action3" value="pageBackward"/>
<option name="Key0" value="&lt;DownArrow&gt;"/>
<option name="Key1" value="&lt;PageDown&gt;"/>
<option name="Key2" value="&lt;PageUp&gt;"/>
<option name="Key3" value="&lt;UpArrow&gt;"/>

I had to change the bold parts.

Thanks again,
I am switching to 0.12.10

Marcel.

[fekhner]

I was using the stylus, but now, after changing the options file, I can also use the sensors

[Iñigo]

Originally Posted by Mackx

Hi Iñigo,

I was looking at Programs\_fbreader\share\FBReader\default\keymap.x ml, that was the wrong file. Thanks for pointing at options.xml.

So for all others: Check your options.xml file for the following entries:
<option name="Action0" value="pageForward"/>
<option name="Action1" value="nextTOCSection"/>
<option name="Action2" value="previousTOCSection"/>
<option name="Action3" value="pageBackward"/>
<option name="Key0" value="&lt;DownArrow&gt;"/>
<option name="Key1" value="&lt;PageDown&gt;"/>
<option name="Key2" value="&lt;PageUp&gt;"/>
<option name="Key3" value="&lt;UpArrow&gt;"/>

I had to change the bold parts.

Thanks again,
I am switching to 0.12.10

Marcel.

let's hope it doesn't crash too much ;-)

[Iñigo]

Hello out there,

as I mentioned in a previous post, I'm thinking on different changes for the default configuration before releasing a version of the package, please comment with your opinions and ideas:

CHANGES:
- start FBReader in fullscreen mode
- change toolbar items
as some features are reachable from menu I think we could reduce / change the number of items on the toolbar.

To remove:
<button id="gotoHome"/>
<button id="undo"/>
<button id="redo"/>
<textField id="gotoPageNumberWithParameter" parameterId="pageIndex" maxWidth="5" symbols="digits"/>
<button id="preferences"/>
<button id="bookInfo"/>
<button id="rotate"/>

To remove? (I'd leave them if there is enough room)
<button id="search"/>
<button id="findPrevious"/>
<button id="findNext"/>

To add:
<button id="increaseFont"/>
<button id="decreaseFont"/>


BUGS:
By now, after some periods of light reading (~20 mins. each), the only bug I've found is that if I open various files with FBReader (f.e. a .fb2 and a .chm) and I close one of them, and then go to Home or Books, I can't come back to FBReader. Running it again does not work either because is running on background.
I think this is related to the "is_multidoc" parameter Mackx commented, but as I had to use another initialization method, I don't know if I can do something with this... Have to study deeper...


FINAL THOUGHTS:
Don't know if it's my own mind, but this version feels a bit faster than 0.10.x.
I also tested some forgotten big .chm files (~40 MB) and it's very usable.


Now, your comments below the line ;-)

__________________________________________________
__________________________________________________
__________________________________________________
__________________________________________________
__________________________________________________

[fekhner]

I am sorry but I cannot comment yet as I am not so far a serious user of fbreader ...

[Iñigo]

Ok, if nobody finds something wrong this will be the final v2 package, to be released on saturday or sunday.

[Mackx]

Originally Posted by Iñigo

I think this is related to the "is_multidoc" parameter Mackx commented, but as I had to use another initialization method, I don't know if I can do something with this... Have to study deeper...

If I remember well, setting is_multidoc to false makes sure that the program is send to the foreground when the program is 'started' again (although I am not 100% sure). I see in the code that it is now put to TRUE, in the 0.10.7 is was FALSE.

eripc_sysd_startup_complete( eripcClient, getpid(), TRUE, xid);

[Iñigo]

Originally Posted by Mackx

If I remember well, setting is_multidoc to false makes sure that the program is send to the foreground when the program is 'started' again (although I am not 100% sure). I see in the code that it is now put to TRUE, in the 0.10.7 is was FALSE.

eripc_sysd_startup_complete( eripcClient, getpid(), TRUE, xid);

It works. Thanks Mackx again.

[Iñigo]

The port is now oficially in-the-wild!

https://www.mobileread.com/forums/sho....php?p=1265744

Thanks Mackx and everyone for the all the ideas and help.