[GUI Plugin] Action Chains - Page 10

ownedbycats · 12-18-2020, 04:45 PM

I suspect the problem might be with Mark Books itself. The Favourites menu plugin has the same problem if you add Show Marked Books to it. I can submit a bug request if you'd like.

capink · 12-18-2020, 05:28 PM

So apparently, when I handled the error the previous time, I normalized the menu entry from "Show marked books (7)" to be "Show marked books" and throw away the number in the parenthesis.

Turned out that when there is only one book marked, calibre changes the menu entry into "Show marked book" which would not match my test:

Code:

if safe_name.startswith("Show marked books")

So, I didn't take account of plural/singular forms

. If this indeed is the only the problem, the solution is just removing the "s" from my test.

You described the problem as a regression from the previous version, while this problem has been there all along. If you can confirm that it only happens when only one book is marked I will release a fix, otherwise, will have to dig deeper to find the cause.

Edit: That is why I was not able to re-produce the behavior, was testing with multiple books marked.

ownedbycats · 12-18-2020, 05:32 PM

Another oddity: When you first start Calibre, it appears as "Show marked books". It doesn't add the (0) until books are marked and then cleared.

In my case, it happened when there were no books marked at all. But maybe removing the plural would help anyways.

capink · 12-18-2020, 05:39 PM

OK, I posted a test version in the second post of this thread. Please try and report back.

ownedbycats · 12-18-2020, 05:41 PM

I filed a bug report, in case it can also be fixed on the Calibre end: https://bugs.launchpad.net/calibre/+bug/1908762

capink · 12-18-2020, 05:44 PM

I don't think it is a bug in Calibre. It is an intended behavior.

ownedbycats · 12-18-2020, 05:47 PM

Yes, it's intended - but it causes some clumsy behaviour so my hopes is perhaps whatever the Reading List plugin does to avoid the issues could also be applied.

capink · 12-18-2020, 05:51 PM

kiwidude designed all his plugins to play nice with his favourites menu plugin (which the code for calibre actions is based on), by inserting a constant attribute called 'favourites_menu_unique_name' if the menu entry changes name.

ownedbycats · 12-18-2020, 05:53 PM

That makes sense.

ownedbycats · 12-18-2020, 05:54 PM

Sorry it's taking so long - I grabbed a random fic to test and it's taking forever to download.

ownedbycats · 12-18-2020, 05:59 PM

It seems to be behaving again, using the same replication steps as I posted earlier. Thank you.

capink · 12-18-2020, 06:04 PM

Good to know, will move it to the first post.

jbacelar · 12-18-2020, 08:57 PM

Version 0.3.3
Show Marked Books. Now it works perfectly.
Thanks a lot.

chaley · 12-19-2020, 06:02 AM

Quote:

Originally Posted by capink

Thank you, it is working properly now. Should make some changes to the plugin today. New version will not be released until a new calibre version with changes you made is released.

Kovid accepted the changes. They are now in the "official" source and will be in the next calibre release.

You should replace the copies you got from my posts with the versions on github.

capink · 12-19-2020, 07:33 AM

Done.

12-18-2020, 05:28 PM	#137
capink Wizard Posts: 1,131 Karma: 1954142 Join Date: Aug 2015 Device: Kindle	So apparently, when I handled the error the previous time, I normalized the menu entry from "Show marked books (7)" to be "Show marked books" and throw away the number in the parenthesis. Turned out that when there is only one book marked, calibre changes the menu entry into "Show marked book" which would not match my test: Code: if safe_name.startswith("Show marked books") So, I didn't take account of plural/singular forms . If this indeed is the only the problem, the solution is just removing the "s" from my test. You described the problem as a regression from the previous version, while this problem has been there all along. If you can confirm that it only happens when only one book is marked I will release a fix, otherwise, will have to dig deeper to find the cause. Edit: That is why I was not able to re-produce the behavior, was testing with multiple books marked. Last edited by capink; 12-18-2020 at 05:30 PM.

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
[Editor Plugin] Editor Chains	capink	Plugins	94	07-03-2024 07:26 PM
Action Chains Resources	capink	Plugins	65	07-01-2024 03:12 PM
[GUI Plugin] Noosfere_util, a companion plugin to noosfere DB	lrpirlet	Plugins	2	08-18-2022 03:15 PM
[GUI Plugin] Save Virtual Libraries To Column (GUI)	chaley	Plugins	14	04-04-2021 05:25 AM

12-18-2020, 04:45 PM	#136
ownedbycats Custom User Title Posts: 9,096 Karma: 62844063 Join Date: Oct 2018 Location: Canada Device: Kobo Libra H2O, formerly Aura HD	I suspect the problem might be with Mark Books itself. The Favourites menu plugin has the same problem if you add Show Marked Books to it. I can submit a bug request if you'd like.

12-18-2020, 05:32 PM	#138
ownedbycats Custom User Title Posts: 9,096 Karma: 62844063 Join Date: Oct 2018 Location: Canada Device: Kobo Libra H2O, formerly Aura HD	Another oddity: When you first start Calibre, it appears as "Show marked books". It doesn't add the (0) until books are marked and then cleared. In my case, it happened when there were no books marked at all. But maybe removing the plural would help anyways.

12-18-2020, 05:39 PM	#139
capink Wizard Posts: 1,131 Karma: 1954142 Join Date: Aug 2015 Device: Kindle	OK, I posted a test version in the second post of this thread. Please try and report back.

12-18-2020, 05:41 PM	#140
ownedbycats Custom User Title Posts: 9,096 Karma: 62844063 Join Date: Oct 2018 Location: Canada Device: Kobo Libra H2O, formerly Aura HD	I filed a bug report, in case it can also be fixed on the Calibre end: https://bugs.launchpad.net/calibre/+bug/1908762

12-18-2020, 05:44 PM	#141
capink Wizard Posts: 1,131 Karma: 1954142 Join Date: Aug 2015 Device: Kindle	I don't think it is a bug in Calibre. It is an intended behavior.

12-18-2020, 05:47 PM	#142
ownedbycats Custom User Title Posts: 9,096 Karma: 62844063 Join Date: Oct 2018 Location: Canada Device: Kobo Libra H2O, formerly Aura HD	Yes, it's intended - but it causes some clumsy behaviour so my hopes is perhaps whatever the Reading List plugin does to avoid the issues could also be applied.

12-18-2020, 05:51 PM	#143
capink Wizard Posts: 1,131 Karma: 1954142 Join Date: Aug 2015 Device: Kindle	kiwidude designed all his plugins to play nice with his favourites menu plugin (which the code for calibre actions is based on), by inserting a constant attribute called 'favourites_menu_unique_name' if the menu entry changes name.

12-18-2020, 05:53 PM	#144
ownedbycats Custom User Title Posts: 9,096 Karma: 62844063 Join Date: Oct 2018 Location: Canada Device: Kobo Libra H2O, formerly Aura HD	That makes sense.

12-18-2020, 05:54 PM	#145
ownedbycats Custom User Title Posts: 9,096 Karma: 62844063 Join Date: Oct 2018 Location: Canada Device: Kobo Libra H2O, formerly Aura HD	Sorry it's taking so long - I grabbed a random fic to test and it's taking forever to download.

12-18-2020, 05:59 PM	#146
ownedbycats Custom User Title Posts: 9,096 Karma: 62844063 Join Date: Oct 2018 Location: Canada Device: Kobo Libra H2O, formerly Aura HD	It seems to be behaving again, using the same replication steps as I posted earlier. Thank you.

Advert

Advert

12-18-2020, 06:04 PM	#147
capink Wizard Posts: 1,131 Karma: 1954142 Join Date: Aug 2015 Device: Kindle	Good to know, will move it to the first post.

12-18-2020, 08:57 PM	#148
jbacelar Interested in the matter Posts: 421 Karma: 426094 Join Date: Dec 2011 Location: Spain, south coast Device: Pocketbook InkPad 3	Version 0.3.3 Show Marked Books. Now it works perfectly. Thanks a lot.

12-19-2020, 07:33 AM	#150
capink Wizard Posts: 1,131 Karma: 1954142 Join Date: Aug 2015 Device: Kindle	Done.