[GUI Plugin] Action Chains

[correoparaappzz]

[ownedbycats]

Is there anything unusual about this chain that would cause it to fail to appear in the Chain Caller dialog?

It used to be part of another chain but then I split it into two (duplicate, rename, and remove the unwanted actions from each).

Strangely, if I rename it, I can temporarily set it but then get an 'invalid action' error and then it disappears.

[Terisa de morgan]

Hello, I've got a request (just for mi comfort, not basic in the plugin): Would it be possible, when you are modifying your chains, to sort the table pressing the header (I think there are another points in calibre where it is done). I have some chains and to look for a specific one is tedious. As I say, if it's possible and not difficult, it will be a big help for me.

Thank you for the plugin, as you can say based on my request, I use it a lot.

[capink]

Originally Posted by Terisa de morgan

Hello, I've got a request (just for mi comfort, not basic in the plugin): Would it be possible, when you are modifying your chains, to sort the table pressing the header (I think there are another points in calibre where it is done). I have some chains and to look for a specific one is tedious. As I say, if it's possible and not difficult, it will be a big help for me.

Thank you for the plugin, as you can say based on my request, I use it a lot.

The Chains table is designed to have a manual sort, because it controls the order of menu items. You can see at the left of the dialog, the up and down buttons as part of that manual sort. That's why automatic sort cannot be done for this particular instance.

One solution for your problem, is to implement text filtering. Since the the table was not designed with filtering in mind, this will take some re-writes for parts of the table (mainly functions in context menu). But also will need disabling moving rows when a filter is applied, among many other things that will need a lot of testing. I am not ready to do this now. Will add it to my to-do list, and maybe will re-visit sometime in the future.

[Terisa de morgan]

Originally Posted by capink

The Chains table is designed to have a manual sort, because it controls the order of menu items. You can see at the left of the dialog, the up and down buttons as part of that manual sort. That's why automatic sort cannot be done for this particular instance.

One solution for your problem, is to implement text filtering. Since the the table was not designed with filtering in mind, this will take some re-writes for parts of the table (mainly functions in context menu). But also will need disabling moving rows when a filter is applied, among many other things that will need a lot of testing. I am not ready to do this now. Will add it to my to-do list, and maybe will re-visit sometime in the future.

Ok, thank you for analyzing it, really.

[capink]

Originally Posted by Terisa de morgan

Ok, thank you for analyzing it, really.

I gave text filtering a go. A test version is attached below. The code changes are not massive, but they affect multiple parts of the plugin, and needs a lot of testing to make sure everything is OK, which I am not really up to.

If anyone feels like testing, download and report any problem. The only change is that there is a text box at the top of the chains dialog, by which you can filter the displayed entries, for easier access.

[ownedbycats]

What does the 'save/restore formats' action do?

[Terisa de morgan]

Originally Posted by capink

I gave text filtering a go. A test version is attached below. The code changes are not massive, but they affect multiple parts of the plugin, and needs a lot of testing to make sure everything is OK, which I am not really up to.

If anyone feels like testing, download and report any problem. The only change is that there is a text box at the top of the chains dialog, by which you can filter the displayed entries, for easier access.

I'm using it and works for now. If I find any issue, I'll be back with it.

[capink]

Originally Posted by ownedbycats

What does the 'save/restore formats' action do?

Back up a format before making any changes to it. Much like calibre does with polish book functionality, when it backs EPUB to EPUB_ORIGINAL.

[ownedbycats]

Issue: When editing a chain, opening the preferences for a new 'selection modifier' action causes Calibre to stop responding until I kill the process.

Running Calibre in debug mode doesn't show anything in the log after the "Hiding splash screen" of initial launch.

EDIT: It may be a result of my saved searches. If I switch to an alternate library with none, I get no freeze.

ANOTHER EDIT: I tested all my searches. All of them are valid, but as shown here, there's a lot of searches, including hierarchical and templates:

[capink]

I am not able to replicate this. Is this related to the new test version?? Also does it happen with any Selection Modifier action? Does only happen with Selection Modifier actions that uses saved searches?

[ownedbycats]

It happens with the current test version, yes. I didn't have any existing modifiers to test with, I was trying to create a new one but opening the settings triggered a freeze.

Very strange behaviour: I created an empty library that copied my existing structure, including saved searches. Everything worked here, creating a new modifier and then opening the settings again. When switching back to my main library, it also worked there.

But then when restarting Calibre, I get freezes until I switch to my test library and back.

Weird, but at least it provides a workaround.

[ownedbycats]

Is anyone else getting crashes from using the 'move rows up/down' buttons too many times in a row?

[Terisa de morgan]

Originally Posted by ownedbycats

Is anyone else getting crashes from using the 'move rows up/down' buttons too many times in a row?

No, I did it a bit and it didn't happen... but I think I probably don't have as many actions as you.

[ownedbycats]

I was thinking something about the amount of chains, or some issue with the JSON.