[GUI Plugin] Reading Goal

[thiago.eec]

Not really. The fact is that added a check to see if there are columns in the current dialog, so the plugin can save the sizes. The date input dialog has no columns, so it should just skip this test, like the Statistics dialog does. But, for some reason, it can find the test, so I had to bypass it manually.

[Terisa de morgan]

Originally Posted by thiago.eec

My bad. I'll release the fix in a few moments.

No issue, the only problem is that, when this happens, the only way to solve it is closing calibre And i'ts working now, thank you.

[ownedbycats]

Would it be possible to add a full datetime tooltip to the individual records?



EDIT: The tooltip is there, just bound to the Progress column for some reason. I suspect this maybe leftover from adding the Series column.

[kemonine]

I just updated calibre to 7.20.0 and the latest plugin. I'm now getting a pop-up that says "9 of your reading goal books were removed from calibre. Choose what to do in the next dialog". When I click "OK" I get the following error. Is there anything I can do to sort this or is it a known issue?

Traceback (most recent call last):
  File "calibre_plugins.Reading_Goal.ui", line 276, in set_main_action
    self.tools.manage_reading_goal(option=option)
  File "calibre_plugins.Reading_Goal.main", line 211, in manage_reading_goal
    result = self.update_database(db, data)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "calibre_plugins.Reading_Goal.main", line 996, in update_database
    self.manage_deleted_books(db, data, missing_books)
  File "calibre_plugins.Reading_Goal.main", line 1305, in manage_deleted_books
    tree = self.edit_tree(data, ids=missing_books)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "calibre_plugins.Reading_Goal.main", line 2012, in edit_tree
    values['series'], values['status'], values['date'], values['page_count'],
    ~~~~~~^^^^^^^^^^
KeyError: 'series'

[thiago.eec]

Originally Posted by ownedbycats

EDIT: The tooltip is there, just bound to the Progress column for some reason. I suspect this maybe leftover from adding the Series column.

Yep. I moved it to the right place now.

Originally Posted by kemonine

I just updated calibre to 7.20.0 and the latest plugin. I'm now getting a pop-up that says "9 of your reading goal books were removed from calibre. Choose what to do in the next dialog". When I click "OK" I get the following error. Is there anything I can do to sort this or is it a known issue?

First, the plugin detected that you have deleted 9 of the books that were in your goal, so you must either delete them from your goal too or link them to another entries, in case you readded the deleted books.

Now, the error happened because of an incredible coincidence: the first time you used the new version was also when the 9 books were deleted, so the plugin didn't have the chance to update the database and include the series information.

But it's fixed now. I'll release the new version in a few moments, and you will be able to see the missing books dialog.

[thiago.eec]

Version 1.7.4 - 27 Oct 2024

- Bug fix:

• Move the records' date tooltip to the right place
• Handle an exception when first using the new database scheme and also having missing books

[ownedbycats]

Question: I notice that the pages per day doesn't seem to take into account the current date - e.g. I have a book that I haven't read since the 17th, but the 34 pages a day hasn't changed and it still says '3 days to finish.' Is intentional?

[thiago.eec]

Yes. It only updates when you add a new record.

[ownedbycats]

Updating the Genres column fails to update the genres on an abandoned book. I was able to use Add to Reading Goal to update it, though I then had to re-mark as abandoned.

EDIT: Separately: I was cleaning out the undated 0% records and found that deleting a record from a previous year's book results in "invalid year" errors, one for each book edited, when apply changes. Changes still get saved and nothing seems broken, at least on the scope of the bug fixed in 1.2.6.

ANOTHER EDIT: Also a suggestion to change 'No Genre' to something like '[No Genre]' so it'll sort to the top and be more noticeable - it took me over a week to notice that my mistake here actually overwrote the column entirely and then left them empty after I cleaned up the mess.

[thiago.eec]

Originally Posted by ownedbycats

Updating the Genres column fails to update the genres on an abandoned book. I was able to use Add to Reading Goal to update it, though I then had to re-mark as abandoned.

That's by design. Abandoned books are not update. You could even remove the book from calibre, if you want.

Originally Posted by ownedbycats

EDIT: Separately: I was cleaning out the undated 0% records and found that deleting a record from a previous year's book results in "invalid year" errors, one for each book edited, when apply changes. Changes still get saved and nothing seems broken, at least on the scope of the bug fixed in 1.2.6.

Yes, it's a bug. I'll investigate it.

Originally Posted by ownedbycats

ANOTHER EDIT: Also a suggestion to change 'No Genre' to something like '[No Genre]' so it'll sort to the top and be more noticeable - it took me over a week to notice that my mistake here actually overwrote the column entirely and then left them empty after I cleaned up the mess.

Good idea. I'll implement it.

[ownedbycats]

Since I have a bunch of 2023 books I want to remove the undated records from, I'll be willing to test.

[thiago.eec]

Version 1.7.5 - 31 Oct 2024

- Bug fix: prevent 'invalid year' message when deleting records from past years
- Change 'No genre' to '[No genre]', so it appears on top in 'Genre view'

[ownedbycats]

It works