Sigil-2.2.0 Released - Page 5

KevinH · 06-24-2024, 08:14 PM

Just a caveat, you can have more than one file with the exact same filename and extension as long as they are in different folders (have different paths). This tool would as it is here would not handle that case well.

BeckyEbook · Yesterday, 10:20 AM

Small detail: the identifier relating to the cover image is not updated.

Code:

<meta name="cover" content="THIS" />

KevinH · Yesterday, 11:39 AM

It was for my content.opf test case included within that zip. Of course any existing meta cover id must point correctly to a file in the manifest on input to this program otherwise it will remain untouched.

Please zip up the opf you tested with and post it for me in case there is a logic bug I missed.

BeckyEbook · Yesterday, 11:54 AM

Cancel alert. For the most part, everything was OK, but I ended up with an e-book with the wrong cover ID (cover.jpeg instead of cover.jpg), causing that wrong ID to not be changed. That is, all is well, it's just that before running the script you'd better be sure that the identifiers in the OPF file are correct.
I need to add an extra condition for myself when validating files.

KevinH · Yesterday, 12:07 PM

Good to know, thanks!

KevinH · Yesterday, 12:40 PM

FWIW, using the file extension helps prevent name collisions but I really hate seeing the "." as part of an identifier. I think it would be better to split off the extension and then add it back to the end of the filename prepended with an underscore and not a period.

So Cover.jpg as an id would become Cover_jpg

If we remove the extension information completely, then many more name collisions happen as Cover.jpg may be used in Cover.xhtml and other similar things.

What do people think?

Kevin

Yesterday, 10:20 AM	#62
BeckyEbook Guru Posts: 707 Karma: 2180740 Join Date: Jan 2017 Location: Poland Device: Misc	Small detail: the identifier relating to the cover image is not updated. Code: <meta name="cover" content="THIS" />

Yesterday, 11:39 AM	#63
KevinH Sigil Developer Posts: 7,790 Karma: 5446592 Join Date: Nov 2009 Device: many	It was for my content.opf test case included within that zip. Of course any existing meta cover id must point correctly to a file in the manifest on input to this program otherwise it will remain untouched. Please zip up the opf you tested with and post it for me in case there is a logic bug I missed. Last edited by KevinH; Yesterday at 11:51 AM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Sigil-1.3.0 Released	DiapDealer	Sigil	8	09-15-2020 08:03 AM
Sigil-0.9.10 Released	DiapDealer	Sigil	149	11-19-2018 10:20 PM
Sigil-0.8.900 released for testing - Wait for Sigil-0.8.901	KevinH	Sigil	106	10-04-2015 10:41 AM
Sigil 0.8.2 Released	user_none	Sigil	12	12-22-2014 06:02 PM
Sigil 0.7.0 Released	user_none	Sigil	75	03-03-2013 12:41 PM

06-24-2024, 08:14 PM	#61
KevinH Sigil Developer Posts: 7,790 Karma: 5446592 Join Date: Nov 2009 Device: many	Just a caveat, you can have more than one file with the exact same filename and extension as long as they are in different folders (have different paths). This tool would as it is here would not handle that case well.

Yesterday, 11:54 AM	#64
BeckyEbook Guru Posts: 707 Karma: 2180740 Join Date: Jan 2017 Location: Poland Device: Misc	Cancel alert. For the most part, everything was OK, but I ended up with an e-book with the wrong cover ID (cover.jpeg instead of cover.jpg), causing that wrong ID to not be changed. That is, all is well, it's just that before running the script you'd better be sure that the identifiers in the OPF file are correct. I need to add an extra condition for myself when validating files.

Yesterday, 12:07 PM	#65
KevinH Sigil Developer Posts: 7,790 Karma: 5446592 Join Date: Nov 2009 Device: many	Good to know, thanks!

Yesterday, 12:40 PM	#66
KevinH Sigil Developer Posts: 7,790 Karma: 5446592 Join Date: Nov 2009 Device: many	FWIW, using the file extension helps prevent name collisions but I really hate seeing the "." as part of an identifier. I think it would be better to split off the extension and then add it back to the end of the filename prepended with an underscore and not a period. So Cover.jpg as an id would become Cover_jpg If we remove the extension information completely, then many more name collisions happen as Cover.jpg may be used in Cover.xhtml and other similar things. What do people think? Kevin