The opds-reader plugin disappeared after upgrade to calibre 5

[JSWolf]

Originally Posted by DNSB

Leave the old Python 2 version available for them would seem to be the simplest solution.

But can there be two plugin with the same name? There is no way for Calibre to know if a plugin is Calibre 5 compatible or not. So what happens? If there is a name change, anyone using this plugin who is not on MR won't know it's the same plugin just for Calibre 5.

[DNSB]

Originally Posted by JSWolf

But can there be two plugin with the same name? There is no way for Calibre to know if a plugin is Calibre 5 compatible or not. So what happens? If there is a name change, anyone using this plugin who is not on MR won't know it's the same plugin just for Calibre 5.

Add a minimum version check so the Python 3 version won't install on a calibre version less than 5. Ghod knows enough plugins already have that minimum version check baked in.

Look at the Job Spy plugin for example. In it's root __init__.py, you find the following lines:

    name                    = 'Job Spy'
    description           = JS_DESCRIPTION
    supported_platforms     = ['windows', 'osx', 'linux']
    author                  = 'DaltonST'
    version                 = (1, 0, 184)
    minimum_calibre_version = (4, 6, 0)    # originally 2.49.0

Change that tuple to (5,0,0) and happily forget Python 2.

[JSWolf]

Originally Posted by DNSB

Add a minimum version check so the Python 3 version won't install on a calibre version less than 5. Ghod knows enough plugins already have that minimum version check baked in.

Look at the Job Spy plugin for example. In it's root __init__.py, you find the following lines:

    name                    = 'Job Spy'
    description           = JS_DESCRIPTION
    supported_platforms     = ['windows', 'osx', 'linux']
    author                  = 'DaltonST'
    version                 = (1, 0, 184)
    minimum_calibre_version = (4, 6, 0)    # originally 2.49.0

Change that tuple to (5,0,0) and happily forget Python 2.

But what about the Python 2 compatible version? How would that e handled along side a Python 3 version with the same name?

[DNSB]

Originally Posted by JSWolf

But what about the Python 2 compatible version? How would that e handled along side a Python 3 version with the same name?

Not sure but at some point during the calibre 3 beta's, I seem to remember that a maximum_calibre_version was mentioned. Set the old Python 2 only plugins to a maximum_calibre_version of 4,30,0 and should stop the install on calibre 5. The name may need to be changed but that's a matter for the plugin authors.

[thiago.eec]

Originally Posted by JSWolf

But what about the Python 2 compatible version? How would that e handled along side a Python 3 version with the same name?

If the minimum version is set to 5.0.0, those that already installed the plugin, and are staying on version 4.23, will keep their version, since calibre won't update the plugin. They will keep using last compatible version for Python 2. Those with version 5 or later will receive the update.

Only a new user of the plugin, using a Python 2 calibre, won't be able to install it, since they won't have access to a Python 2 version of the plugin.

[JSWolf]

Originally Posted by DNSB

Not sure but at some point during the calibre 3 beta's, I seem to remember that a maximum_calibre_version was mentioned. Set the old Python 2 only plugins to a maximum_calibre_version of 4,30,0 and should stop the install on calibre 5. The name may need to be changed but that's a matter for the plugin authors.

But how will those on 4.23 going to see it in the plugin list?

How will it work to have a Python 2 and a Python 3 version of the same plugin with the same name? Change the name and those that want it won't get it or get it updated.

[JSWolf]

Originally Posted by thiago.eec

If the minimum version is set to 5.0.0, those that already installed the plugin, and are staying on version 4.23, will keep their version, since calibre won't update the plugin. They will keep using last compatible version for Python 2. Those with version 5 or later will receive the update.

Only a new user of the plugin, using a Python 2 calibre, won't be able to install it, since they won't have access to a Python 2 version of the plugin.

But that's the problem that I think needs to be solved.

[theducks]

Originally Posted by JSWolf

But how will those on 4.23 going to see it in the plugin list?

How will it work to have a Python 2 and a Python 3 version of the same plugin with the same name? Change the name and those that want it won't get it or get it updated.

It is only a problem for New users of Down Rev installations.
There will not be any updates for existing users on those, so they have no further need to SEE the update list.

It has already been suggested that Python 3 ONLY PI simply make the Calibre Minimum 5.0.
To all BACKUP your config folders NOW. then all you need to do is install Calibre (the pre-5.x) and restore the config folder (has all the users PI that remain valid)

[thiago.eec]

Originally Posted by JSWolf

But that's the problem that I think needs to be solved.

If the plugin is only python3 compatible, then there's no way to address this automatically.

If you create another plugin just for python3, existing users won't be notified about that. If you update this one, then new users on 4.23 won't be able install it.

A reasonable solution would be posting the last python2 version on separate post (maybe the second post of plugin thread). But it still won't work automatically. New user on 4.23 would have to know about the plugin and download it from here.

The thing is: I don't even think this is a real problem. How often a new user of calibre would install an old version, and also want this specific plugin?

[BetterRed]

This plugin is not in the Index so it must be installed from file - a'la the deDRM PI.

The first post does not conform to the format required by the Plugin Updater, and the author has not asked the moderators to add the plugin to the Index, which they wouldn't do anyway because the first…

I suggest the author take care of previous versions on the Github repo, in the same way as Sigil does.

BR

[JSWolf]

If a plugin has a version that only works with Python 2 Calibre and a version that only works with Python 3 Calibre, how do you make it so those on PY2 can get the plugin and those on PY3 can get the plugin but the name is not changed for either of them? That's the problem. That (IMHO) is what needs to be fixed in Calibre 5.x as well as Calibre 5 not showing any plugins not PY3 ready.

[steinarb]

Originally Posted by jhowell

You should probably update the minimum_calibre_version in your plugin's __init__.py file.

Done: https://github.com/steinarb/opds-rea...05a952de8c9339

[steinarb]

Originally Posted by JSWolf

But there are people who cannot run Calibre 5 but can run 4.23. What about them?

If they don't do a "git pull" on the plugin (I've never packaged it), then it should continue to work.

If they do a "git pull" by mistake, this should fix it:

cd ~/git/opds-reader
git checkout -b calibre4-compatible 8b79f9b
cd calibre_plugin
calibre-customize -b .

[JSWolf]

It's not an issue of git.It's an issue of the plugin system built into Calibre. If you have the same plugin but one runs on PY3 and the other on PY2, there is no way to give the user the correct version based on which version of Calibre is being used. You would have to setup two different threads with the same named plugins. I don't know if Calibre's plugin system can even handle multiple plugins with the same name.